openstack
/
oslo.rootwrap
Code Issues Proposed changes

Fix test_daemon_no_cleanup_for_uninitialized_server 

When mocking daemon_start(), define a string return value for
tempfile.mkdtemp(), ensuring temp_dir is a string when passed to
os.path.join(temp_dir, "rootwrap.sock").

Change-Id: I502c9cc53f40cbea89243a2321d1bc63f05e7c7b
Closes-Bug: 1709505
This commit is contained in:
Corey Bryant 2017-08-16 11:00:21 -04:00
parent 06f1b6f3d7
commit 395a3a8075
1 changed files with 2 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
oslo_rootwrap/tests/test_rootwrap.py
View File

@ -653,6 +653,7 @@ class DaemonCleanupTestCase(testtools.TestCase):
@mock.patch('tempfile.mkdtemp')
@mock.patch('multiprocessing.managers.BaseManager.get_server',
side_effect=DaemonCleanupException)
def test_daemon_no_cleanup_for_uninitialized_server(self, gs, *args):
def test_daemon_no_cleanup_for_uninitialized_server(self, gs, mkd, *args):
mkd.return_value = '/tmp/123'
self.assertRaises(DaemonCleanupException, daemon.daemon_start,
config=None, filters=None)