Commit Graph

583 Commits

Author SHA1 Message Date
Frode Nordahl d5e21c17b2
Fix BFD functional test, avoid comparing status column
The status column is updated by OVN so we cannot rely on its
contents being stable.

The test already attempts to address this by using frozen rows,
but that does not fully solve the issue as objects are created at
different points in time and then compared, which may give
unpredictable results.

Filter out the `status` column from the affected tests.

Closes-Bug: #2058264
Change-Id: Ibaa54d93109434b445f54de583f534021defccbb
Signed-off-by: Frode Nordahl <fnordahl@ubuntu.com>
2024-03-21 07:29:35 +01:00
Zuul 1ddf16801f Merge "Update master for stable/2024.1" 2024-03-19 13:53:09 +00:00
Zuul 4a23026174 Merge "nb: commands: fix passing string to LSP attach/detach mirror API" 2024-03-18 21:33:18 +00:00
Seena Fallah f86a5985e7 ovn-sb: remove chassis from Chassis_Private on ChassisDelCommand
When deleting a chassis from OVN Southbound it should be also deleted from Chassis_Private table

Signed-off-by: Seena Fallah <seenafallah@gmail.com>
Change-Id: Ibff5fb6c4a809e798b5cf0e70f0861264043c7ba
2024-03-18 14:24:39 +00:00
OpenStack Release Bot 271ed4c222 Update master for stable/2024.1
Add file to the reno documentation build to show release notes for
stable/2024.1.

Use pbr instruction to increment the minor version number
automatically so that master versions are higher than the versions on
stable/2024.1.

Sem-Ver: feature
Change-Id: I5b86f41d5841636b94fe5be243f243dd08a6fe8a
2024-03-07 15:38:26 +00:00
Zuul 7a242c6ed8 Merge "reno: Update master for unmaintained/victoria" 2024-03-07 15:23:14 +00:00
Zuul ac5d599260 Merge "reno: Update master for unmaintained/wallaby" 2024-03-07 15:21:45 +00:00
OpenStack Release Bot 4b6ece964f reno: Update master for unmaintained/xena
Update the xena release notes configuration to build from
unmaintained/xena.

Change-Id: I90e829472ed5353f63f54a6f7ed52014498d7229
2024-03-06 12:21:20 +00:00
OpenStack Release Bot ac63e1bb17 reno: Update master for unmaintained/wallaby
Update the wallaby release notes configuration to build from
unmaintained/wallaby.

Change-Id: Ifafbc4cc9ad107d40184dbd0996abb2bd4692305
2024-03-06 12:13:40 +00:00
OpenStack Release Bot e7281578ab reno: Update master for unmaintained/victoria
Update the victoria release notes configuration to build from
unmaintained/victoria.

Change-Id: I7074a4d86f12f9f4bf51edf37e890de8440b4170
2024-03-06 12:03:33 +00:00
Dmitrii Skorykh f9ec5ac7c8 nb: commands: fix passing string to LSP attach/detach mirror API
Pass an instance of idlutils.Row mirror as a value instead of raw string/uuid
to addvalue/delvalue methods since OVS library Atom.from_python() ctor
doesn't expect string as an argument.

Closes-bug: #2055094
Change-Id: Ibc1a5aaefe68f7e02f92285900654c9f70aed69e
2024-02-27 01:16:11 +03:00
Zuul 11b11a1108 Merge "Update supported python versions" 2024-02-20 14:18:36 +00:00
OpenStack Release Bot be6e8d10fb reno: Update master for unmaintained/yoga
Update the yoga release notes configuration to build from
unmaintained/yoga.

Change-Id: I338bf44421a41e1216c0fee8d21cb4ba2395de34
2024-02-05 16:47:11 +00:00
Takashi Kajinami b9b15d89cf tox: Drop envdir
tox now always recreates an env although the env is shared using envdir
options.
~~~
$ tox -e genpolicy
genpolicy: recreate env because env type changed from
{'name': 'genconfig', 'type': 'VirtualEnvRunner'} to
{'name': 'genpolicy', 'type': 'VirtualEnvRunner'}
~~~

According to the maintainer of tox, this functionality is not intended
to be supported.
https://github.com/tox-dev/tox/issues/425#issuecomment-1011944293

Change-Id: I63264b8c11ceea4b312b251c9a28f4a246592733
2024-02-03 00:04:59 +09:00
Zuul fc9f465f60 Merge "Bump hacking" 2024-01-30 11:12:33 +00:00
Takashi Kajinami e62823d134 Bump hacking
... because hacking 3.0.x is too old. pylint is also bumped to resolve
conflicting dependencies. The new version is currently used in neutron.
The pylint setting is imported from neutron with one additional
disablement to ignore the following error.

ovsdbapp/schema/open_vswitch/helpers.py:47:14: R1732: Consider using
'with' for resource-allocating operations (consider-using-with)

Change-Id: I41b4524ff13b8d46d2e0c76f09b5ec47601bd955
2024-01-27 23:14:24 +09:00
liushy 374bf64068 Support add/remove CIDR type address in Address_Set cmds
Related-Bug: #1982287
Change-Id: I6bfd486bf037da5b4d2dd61c84a50d6a7fbfb39d
2024-01-11 11:55:14 +08:00
Takashi Kajinami 155bed69a7 Update supported python versions
Python 3.10 and 3.11 are now part of the tested runtimes.

Change-Id: Iee9578401a7501b97f5f03bbd846b93e450f51b6
2023-12-20 00:01:50 +09:00
Zuul 1cb9acc015 Merge "add Port_Binding to lookup_table" 2023-12-09 23:41:33 +00:00
Max Lamprecht a8ea64e028 add Port_Binding to lookup_table
Currently the index logical_port on Port_Binding
is missing because autocreate_indices() skips
indexes with multiple columns:
-> "indexes": [["datapath", "tunnel_key"], ["logical_port"]]

This slows down the ovn-bgp-agent at scale(31060 Port_Binding
entries) heavily. (See bug #https://bugs.launchpad.net/ovn-bgp-agent/+bug/2045892)

Full sync iteration:
Without Port_Binding index: ~6min
With Port_Binding index: ~5sec

Closes-Bug: #2045892
Change-Id: I815c695fd8a5e12a94e02a7a29da8aadc99541c4
2023-12-07 11:45:36 +01:00
Zuul 8e55b0b74c Merge "venv: unit tests don't work for 'hardware_vtep'" 2023-11-17 18:21:38 +00:00
Zuul c22fbe766b Merge "Handle events with conditions and match_fn" 2023-11-16 20:43:49 +00:00
Zuul 21d663a475 Merge "TAAS: Add commands for creating Mirrors" 2023-11-16 20:37:14 +00:00
Anton Vazhnetsov ef564d64aa nb: allow to add route even if learned route exists
Allow to install static route even if static route with same CIDR has
been learned by ovn-ic from another AZ.

See this commit for more information: 68105f68c3

Closes-bug: 2037573

Change-Id: I2a7a110551ee302dc9602ef6b01153262ea637d4
2023-11-15 20:20:40 +03:00
elajkat 02a7b2b7a8 TAAS: Add commands for creating Mirrors
Note: mirrors are available only from OVN v22.12.0

Change-Id: I8d70d24beefb2813c977e9f89aa0535c3494ee85
Related-Bug: #2015471
2023-10-31 16:13:10 +01:00
Anton Vazhnetsov dae455b6ee nb: provide 'route_table' in lr-route-{add,del,list}
Adds possibility to specify 'route_table' in methods for static
routes.

See this commit for more information:
1655a6c146

Closes-bug: 2037652

Change-Id: Ic965ae098adb6db2e5a057eee74250e3b6331b01
2023-10-04 18:16:03 +03:00
Anton Vazhnetsov 033b6e3bd2 nb: add 'nexthop' argument to 'lr_route_del'
In request https://review.opendev.org/c/openstack/ovsdbapp/+/882268, the ability to create ECMP routes was added. This PR adds the ability to delete these routes.

Closes-bug: 2037536

Change-Id: I84f234c6c5bbf4d318893166943de62fb87fff69
2023-10-04 18:06:31 +03:00
Terry Wilson 61935457bd Handle events with conditions and match_fn
The original goal of adding match_fn() the ovs_idl backend
implementation of RowEvent was to give an option to specify more
complex matching behavior than conditions/old_conditions allowed.

It was never intended that users would use both together, but it
also was not documented that that was the case. This patch allows
conditions and match_fn() to be treated as a logical AND to avoid
accidentally removing conditions when adding a match_fn()

Change-Id: Ifc18bf42e2a0ce8247bf986d14646f66d9554ca7
2023-10-03 14:14:33 -05:00
Anton Vazhnetsov dd56fd5bea venv: unit tests don't work for 'hardware_vtep'
If OVN and OVS are not installed on the system, but cloned into '.venv',
the 'OvsVtepVenvFixture' class is not instantiated correctly and all
unit tests fail.

Closes-bug: 2037568

Change-Id: Id26004b57cb02900faed5dabeee8956ff9c66b54
2023-09-27 23:56:49 +03:00
OpenStack Release Bot a39b4f8e62 Update master for stable/2023.2
Add file to the reno documentation build to show release notes for
stable/2023.2.

Use pbr instruction to increment the minor version number
automatically so that master versions are higher than the versions on
stable/2023.2.

Sem-Ver: feature
Change-Id: Ie46f51ba773dfa7dc321f954aafd269fff9fa194
2023-09-07 09:41:39 +00:00
Terry Wilson 6f7aed7098 Add some basic usage documentation
This adds some basic usage documentation and a simple tutorial for
ovsdbapp.

Change-Id: I19583b439f0d8488e957265d89309abf08d307e7
2023-07-18 16:57:27 -05:00
Zuul d542e5cee1 Merge "Ensure LrpAddCommand may_exits works without peers" 2023-05-30 14:23:22 +00:00
Luis Tomas Bolivar 267286976e Ensure LrpAddCommand may_exits works without peers
This patch sets the default for peers to [] instead of None, to match
what it is stored on the DB

Closes-Bug: #2019109
Change-Id: I66948039e61503480fd140ee9e0ce645a6ef4453
2023-05-24 16:49:07 +02:00
Luis Tomas Bolivar cc1ddf6a9e Add support for ecmp routes
Add ECMP support so that routes with different nexthops but
same ip_prefix can be added

Change-Id: I57e0caa4e604a1152f5015a6aabf3b52349b3a02
2023-05-16 09:07:09 +02:00
Zuul 770f77d86f Merge "Add if_exists and **kwargs columns to db_set" 2023-04-20 16:16:06 +00:00
Zuul e77599280b Merge "Add support for manipulating BFD entries" 2023-04-20 16:14:54 +00:00
Zuul 2b9895b346 Merge "Add 'no timeout' option to wait_for_change" 2023-04-19 17:19:23 +00:00
Frode Nordahl f8fe13af90
Add support for manipulating BFD entries
Related-Bug: #2002687
Signed-off-by: Frode Nordahl <frode.nordahl@canonical.com>
Change-Id: I0e49a0d60f40991e21f2b3f94cd99f43b07fd639
2023-04-19 19:14:38 +02:00
Terry Wilson 6ab3f75388 Add if_exists and **kwargs columns to db_set
The original API for db_set() out of an over-abundance of caution
use *args tuples in the format of ('column_name', value) due to the
fear that there may be OVSDB column names that were not valid
Python argument names (e.g. 'some-column'). But the OVSDB RFC
forbids column names that would be a problem.

This patch adds **columns which will be used only if there are
no values passed as *col_values. It also adds if_exists support
to db_set(), as there are situations where you don't want to throw
an error if you are updating a Row in a multi-op transaction and
it's possible that the row has been deleted on the server.

Change-Id: Ia17e545706a16f5c726ec52bae339e9362b0b614
2023-04-19 14:34:08 +00:00
Terry Wilson d1afa56c2d Add 'no timeout' option to wait_for_change
Neutron currently overrides wait_for_change because it needs a
version without a timeout. This adds the ability to set either
timeout=None or timeout <= 0 to not timeout.

Change-Id: Iff708c259a5500848eab73b05da70300ff8e4134
2023-04-18 18:23:46 -05:00
Rodolfo Alonso Hernandez ab6682e3f6 Add Interface paramteres to ``OvsdbIdl.add_port`` method.
Now it is possible to define the "Interface" parameters when creating
a "Port" register (a "Interface" register is created along with any
new "Port").

Related-Bug: #2006603
Change-Id: I6b946ef27b38e76fd70d2b529d645f5f09ac2404
2023-04-14 15:49:04 +02:00
Luis Tomas Bolivar f2c5a39edd Add new function ls_get_localnet_ports
This is used to detect if a given logical_switch has localnet
ports associated to it, and return them

Change-Id: Iabfc1bd0a1b2c6998a013d19c47cda10a3879c82
2023-04-04 13:36:11 +00:00
Terry Wilson ee28e381fb Use OVN's OVS submodule for functional tests
The OVN tree for several years has had an OVS submodule that pulls
in the version of OVS it is guaranteed to work with. There is
currently a patch in OVS master that breaks the build of OVN main
so switch to using the submodule.

Change-Id: I61195cd3ebf8a5015890d3ba3988c3d9795ee817
2023-04-03 15:46:39 -05:00
Rodolfo Alonso Hernandez 2ed1280148 [CI] Set the default OS_TEST_PATH in the stestr conf file
Set the default OS_TEST_PATH in the stestr configuration file. Any
other test environment can overwrite this variable in the "setenv"
section.

Change-Id: I51564920cec916031aaebf8151b015a3d87e9471
2023-03-16 15:29:18 +01:00
OpenStack Release Bot 54dc562a1d Update master for stable/2023.1
Add file to the reno documentation build to show release notes for
stable/2023.1.

Use pbr instruction to increment the minor version number
automatically so that master versions are higher than the versions on
stable/2023.1.

Sem-Ver: feature
Change-Id: Ie65e709d20526528f35cc13b2a8cc393ea086deb
2023-03-02 13:26:30 +00:00
Rodolfo Alonso Hernandez 019f0a2acb All ``AddCommand`` child classes return the new register UUID
This patch fixes the return of two classes, ``HealthCheckAddCommand``
and ``GatewayChassisAddCommand``, that instead the new register UUID
were returning the register ifself.

NOTE:
* ``HealthCheckAddCommand`` is only used in ``LbAddHealthCheckCommand``
  (it has no IDL API method). It is tested in [1].
* ``GatewayChassisAddCommand`` is used in ``LrpAddCommand`` and
  ``LrpSetGatewayChassisCommand`` (it has no IDL API method). It is
  tested in [2] and [3].

[1]96cf8d6288/ovsdbapp/tests/functional/schema/ovn_northbound/test_impl_idl.py (L1731-L1762)
[2]96cf8d6288/ovsdbapp/tests/functional/schema/ovn_northbound/test_impl_idl.py (L1531-L1552)
[3]96cf8d6288/ovsdbapp/tests/functional/schema/ovn_northbound/test_impl_idl.py (L1505-L1516)

Closes-Bug: #2004170

Change-Id: I48df608aedce3012a2ae7aa4de636fa837bd47aa
2023-02-02 07:39:37 +00:00
Rodolfo Alonso Hernandez 7733f0c536 Define "LbAddIpPortMappingCommand" with latin chars
Closes-Bug: #2004186
Change-Id: Ic0e28b1113b6af1c66e6301e1851b620eac19824
2023-02-02 07:39:32 +00:00
Rodolfo Alonso Hernandez c8e7e9f619 Accept HA chassis group commands in HAChassisGroupAdd*
Now "HAChassisGroupAddChassisCommand" and
"HAChassisGroupDelChassisCommand" accept "HAChassisGroupAddCommand"
as input parameter.

That allows to add and remove "HA_Chassis" from the "HA_Chassis_Group"
register in the same transaction that has created the HA Chassis
Group.

Related-Bug: #1995078
Change-Id: I443796cc2fcd7eef46f968a8383d068bab6ae670
2023-02-01 09:51:07 +00:00
Rodolfo Alonso Hernandez 149d7db4a7 Update tox.ini for tox4
Change-Id: I7ec80abf6bda33ad3f074309f64491ee4af1c71b
2023-01-23 16:28:52 +01:00
Takashi Natsume 5f429b7230 Use daemon property instead of setDaemon method
The setDaemon method of the threading.Thread was deprecated
in Python 3.10 (*).
Replace the setDaemon method with the daemon property.

*: https://docs.python.org/3.10/library/threading.html#threading.Thread.setDaemon

Change-Id: Id4b6df45ba4741e410692df7bd11db3f56f00f45
Signed-off-by: Takashi Natsume <takanattie@gmail.com>
2022-11-03 02:56:03 +00:00