Required for handling the cases where set_options
is called on non-existing logical router port.
The option is added to parent class BaseSetOptionsCommand, so
if other apis relying on that need to expose if_exists then those
can be extended in future.
Partial-Bug: #2065701
Related-Bug: #2060163
Change-Id: I56685478214aae7b6d3a2a3187297ad4eb1869a3
Before the patch, the code was always attempting to rebuild indices and
start a connection, even if a connection was already started and cached
in .ovsdb_connection class attribute.
(Both operations were gracefully handled as no-ops. But they left some
confusing log messages about indices rebuild etc.)
Change-Id: Ib9ef29da251f5d184fa6abd20e1b17010f2ed1a1
netaddr 0.10 added flags to define the semantics while parsing
IP addresses. available are inet_pton() and inet_aton() semantics,
which inet_aton() semantics the default in 0.10 and inet_pton() the
default in 1.x. As the testsuite specifically tests for aton semantics,
set that flag.
Change-Id: I06eec5619f958f6c4b90f6068c361a18c2356be6
'pre-commit' tool [1] provides an extensible way to configure hooks
which can be run automatically before each commit. That way we can make
sure that code send to review is passing base static analysis checks
like e.g. bandit, flake8 or hacking.
For now this is optional to use and not integrated in e.g. tox.ini file
but we can integrate it there too as next step.
[1] https://pre-commit.com/
Change-Id: I2338df66512e900a4cd04e9717cb19cc6ade48d2
The ovn-nb manpage states that for v6 addresses, the IPs need to
be enclosed in brackets for Load_Balancer.ip_port_mappings.
Closes-Bug: #2057471
Signed-off-by: Terry Wilson <twilson@redhat.com>
Change-Id: If93037f35723c56d3da635e1a7aa42c092c8e7d6
The status column is updated by OVN so we cannot rely on its
contents being stable.
The test already attempts to address this by using frozen rows,
but that does not fully solve the issue as objects are created at
different points in time and then compared, which may give
unpredictable results.
Filter out the `status` column from the affected tests.
Closes-Bug: #2058264
Change-Id: Ibaa54d93109434b445f54de583f534021defccbb
Signed-off-by: Frode Nordahl <fnordahl@ubuntu.com>
When deleting a chassis from OVN Southbound it should be also deleted from Chassis_Private table
Signed-off-by: Seena Fallah <seenafallah@gmail.com>
Change-Id: Ibff5fb6c4a809e798b5cf0e70f0861264043c7ba
Add file to the reno documentation build to show release notes for
stable/2024.1.
Use pbr instruction to increment the minor version number
automatically so that master versions are higher than the versions on
stable/2024.1.
Sem-Ver: feature
Change-Id: I5b86f41d5841636b94fe5be243f243dd08a6fe8a
Pass an instance of idlutils.Row mirror as a value instead of raw string/uuid
to addvalue/delvalue methods since OVS library Atom.from_python() ctor
doesn't expect string as an argument.
Closes-bug: #2055094
Change-Id: Ibc1a5aaefe68f7e02f92285900654c9f70aed69e
tox now always recreates an env although the env is shared using envdir
options.
~~~
$ tox -e genpolicy
genpolicy: recreate env because env type changed from
{'name': 'genconfig', 'type': 'VirtualEnvRunner'} to
{'name': 'genpolicy', 'type': 'VirtualEnvRunner'}
~~~
According to the maintainer of tox, this functionality is not intended
to be supported.
https://github.com/tox-dev/tox/issues/425#issuecomment-1011944293
Change-Id: I63264b8c11ceea4b312b251c9a28f4a246592733
... because hacking 3.0.x is too old. pylint is also bumped to resolve
conflicting dependencies. The new version is currently used in neutron.
The pylint setting is imported from neutron with one additional
disablement to ignore the following error.
ovsdbapp/schema/open_vswitch/helpers.py:47:14: R1732: Consider using
'with' for resource-allocating operations (consider-using-with)
Change-Id: I41b4524ff13b8d46d2e0c76f09b5ec47601bd955
Currently the index logical_port on Port_Binding
is missing because autocreate_indices() skips
indexes with multiple columns:
-> "indexes": [["datapath", "tunnel_key"], ["logical_port"]]
This slows down the ovn-bgp-agent at scale(31060 Port_Binding
entries) heavily. (See bug #https://bugs.launchpad.net/ovn-bgp-agent/+bug/2045892)
Full sync iteration:
Without Port_Binding index: ~6min
With Port_Binding index: ~5sec
Closes-Bug: #2045892
Change-Id: I815c695fd8a5e12a94e02a7a29da8aadc99541c4
Allow to install static route even if static route with same CIDR has
been learned by ovn-ic from another AZ.
See this commit for more information: 68105f68c3
Closes-bug: 2037573
Change-Id: I2a7a110551ee302dc9602ef6b01153262ea637d4
Adds possibility to specify 'route_table' in methods for static
routes.
See this commit for more information:
1655a6c146
Closes-bug: 2037652
Change-Id: Ic965ae098adb6db2e5a057eee74250e3b6331b01
In request https://review.opendev.org/c/openstack/ovsdbapp/+/882268, the ability to create ECMP routes was added. This PR adds the ability to delete these routes.
Closes-bug: 2037536
Change-Id: I84f234c6c5bbf4d318893166943de62fb87fff69
The original goal of adding match_fn() the ovs_idl backend
implementation of RowEvent was to give an option to specify more
complex matching behavior than conditions/old_conditions allowed.
It was never intended that users would use both together, but it
also was not documented that that was the case. This patch allows
conditions and match_fn() to be treated as a logical AND to avoid
accidentally removing conditions when adding a match_fn()
Change-Id: Ifc18bf42e2a0ce8247bf986d14646f66d9554ca7
If OVN and OVS are not installed on the system, but cloned into '.venv',
the 'OvsVtepVenvFixture' class is not instantiated correctly and all
unit tests fail.
Closes-bug: 2037568
Change-Id: Id26004b57cb02900faed5dabeee8956ff9c66b54
Add file to the reno documentation build to show release notes for
stable/2023.2.
Use pbr instruction to increment the minor version number
automatically so that master versions are higher than the versions on
stable/2023.2.
Sem-Ver: feature
Change-Id: Ie46f51ba773dfa7dc321f954aafd269fff9fa194
This patch sets the default for peers to [] instead of None, to match
what it is stored on the DB
Closes-Bug: #2019109
Change-Id: I66948039e61503480fd140ee9e0ce645a6ef4453