Commit Graph

29 Commits

Author SHA1 Message Date
Joel Capitao 8726503615 Replace deprecated defined resource type of Manila
Since [1], 'manila::service_instance' has been replaced
by 'manila::backend::service_instance'.

We have also to remove the use of
'use_guestagent_template' as it was removed in [2]

Finally, since tox4 we need to set skipdist to False
in order to install the package (needed for pbr to
get the version). Previously with tox3, it was set to
True but it was a bug apprently.

[1] https://review.opendev.org/c/openstack/puppet-manila/+/873479
[2] https://review.opendev.org/c/openstack/puppet-trove/+/874367

Change-Id: I464675a5f78b1efcc3a277da4772dca5690dd842
2023-02-22 12:36:31 +01:00
Joel Capitao 6f9aedc4a3 Trove: Use trove::db to set up database options
... because database options of the base trove class have been
deprecated.

Remove CentOS Stream 8 jobs

RDO Zed (currently master) will only support
CentOS Stream 9 [1].
The CS8 DLRN builder is about to be stopped
and removed, so we can get rid of the CS8 jobs.

Plus we need to require "six" explicitly.
Until now, it was installed as transitive dependency.

[1] https://lists.rdoproject.org/archives/list/dev@lists.rdoproject.org/thread/EKPN4RMQEKYS3ZAHRUHZQ47IF7QXOLZH/

Change-Id: Ib82083f328c3e23b07559652e31acb0153c61a43
2022-07-01 14:15:08 +02:00
Javier Pena 3048287985 Update to a newer hacking version, fix pep8 errors
We had a very old hacking version, so we should update it to the
same version as other projects are using. The update also required
additional changes to the Python code to fix new errors and
warnings.

Change-Id: Ic511513057581841fe2230b69a2a413ec0981f15
2020-09-24 15:35:58 +02:00
Alfredo Moralejo e68d358532 Use upper-constraints file when running tests
Currently, u-c is not uses so we are not using the versions specified in
requirements project.

Change-Id: Id0fd9e98103ff804a43f2d4485f72ac48df261c8
2019-07-22 12:01:33 +02:00
Vieri 82ffab2fac Update min tox version to 2.0
The commands used by constraints need at least tox 2.0.  Update to
reflect reality, which should help with local running of constraints
targets.

Change-Id: I4dd23787410d69354adede815937954b553942be
Closes-Bug:  #1801461
2018-11-08 12:18:12 +00:00
Javier Pena e2c31de9b3 Initial Python 3 support
Packstack needs to get adapted to Python 3. This patch adds initial
compatibility fixes and a tox-py36 job (non-voting) to test it.

Change-Id: I653454b523224615ea5f0e9f5a7d799031f57649
2018-09-27 09:13:06 +00:00
Charles Short b64b16f5a2 Switch to using stestr
According to Openstack summit session [1] stestr is
maintained project to which all Openstack projects
should migrate.
Let's switch it then.

[1] https://etherpad.openstack.org/p/YVR-python-pti

Change-Id: I2fdbbafb9ec36c7bcbab6038387aaa31f41316dd
Signed-off-by: Charles Short <zulcss@gmail.com>
2018-06-05 09:04:31 -04:00
Javier Pena df7cb04857 Zuul v3 support for Packstack jobs
- Do not generate the SSH private key if it already exists
- Set skipsdist = True in tox.ini
- Add Zuul v3 layout

Change-Id: I4b0254bf175d51c0a468b01f8ac034db43859572
2017-10-16 12:55:47 +02:00
Javier Pena 31c85d484f Move tox dependencies to requirements.txt/test-requirements.txt
Previously we had our requirements in two different places:
requirements/test-requirements for normal installation, and
tools/pip-requires & tools/test-requires for tox tests. Let's
unify them on a single location.

Change-Id: I3e31eeb70e7db24d87b8a7c67a427c53af814a32
2016-11-30 14:35:45 +01:00
Maciej Kucia eb2ab2ba53 Use ostestr instead of nosetest
This change aligns packstack unit tests runner with other Open Stack projects

Change-Id: I588f12a163e64d90a51f35e98ea20ff691339baa
Signed-off-by: Maciej Kucia <maciej@kucia.net>
2016-10-30 21:09:43 +01:00
Alan Pevec 1bbcbff4fb Use PBR
Refactor setup.py using Python Build Reasonableness[1]
as a standard for OpenStack projects.

[1] http://docs.openstack.org/developer/pbr/

Closes-Bug: #1559150
Change-Id: Ie3b3845f11236f5338228690418760599914cce4
2016-09-21 17:49:02 +02:00
David Moreau Simard e9646e5c7f Start managing release notes in Packstack with Reno
Change-Id: I0d44c418ec8702958dc64016698c9764d3527fdd
2016-03-21 14:06:38 -04:00
Jenkins 28e74215ad Merge "Deprecated tox -downloadcache option removed" 2016-01-05 12:50:00 +00:00
janonymous b2f809e4f0 py26 is no longer supported by Infra's CI
Python 2.6 support would be dropped by
Infra team from mitaka,CI would no longer be testing it,
so projects should drop it too.

Change-Id: Ic96f4c44cb833ca6199c9daf1078f4d0715aedad
2015-12-26 15:18:31 +05:30
Ondřej Nový 7e65850aec Deprecated tox -downloadcache option removed
Caching is enabled by default from pip version 6.0

More info:
https://testrun.org/tox/latest/config.html#confval-downloadcache=path
https://pip.pypa.io/en/stable/reference/pip_install/#caching

Change-Id: If184b12d353c2179aac1c1e116d1b8864195d7b6
2015-12-11 23:20:13 +01:00
Lukas Bezdicka aa45027939 [Packstack] enchange ipv6 support
We should support ipv6 or ipv4 only installation and we should
set firewall according to ip version.

Resolves-Bug: rhbz#1185652
Change-Id: I7bacf81373a6e0567e0c3fdebacf47cd5c683ad2
2015-04-15 09:17:48 +02:00
Christian Berendt d7916cec60 Enable PEP8 checks H102, H232, H233, H301, H904
* H102  Apache 2.0 license header not found
* H232  Python 3.x incompatible octal xxx should be written as 0oxxx
* H233  Python 3.x incompatible use of print operator
* H301  one import per line
* H904  Wrap long lines in parentheses instead of a backslash

Change-Id: I07003acb76eaa719daabc451239067494efa2bba
2015-02-02 10:45:44 +01:00
Christian Berendt c532db1461 Enable several PEP8 checks
* E122 continuation line missing indentation or outdented
* E126 continuation line over-indented for hanging indent
* E127 continuation line over-indented for visual indent
* E128 continuation line under-indented for visual indent
* E131 continuation line unaligned for hanging indent
* E303 too many blank lines
* W601 .has_key() is deprecated, use 'in'
* H234 assertEquals is deprecated, use assertEqual
* H401 docstring should not start with a space
* H402 one line docstring needs punctuation.

Change-Id: I1c264dba19bfe7cb9173e8999429827bd026b930
2015-01-21 19:11:49 +01:00
Christian Berendt 1e93a38908 Enable PEP8 checks for E111, E241, E261, E401, E502, E713, E721
* E111 indentation is not a multiple of four
* E241 multiple spaces after ','
* E261 at least two spaces before inline comment
* E401 multiple imports on one line
* E502 the backslash is redundant between brackets
* E713 test for membership should be 'not in'
* E721 do not compare types, use 'isinstance()'

Change-Id: I7315dac1734e6adc4ecf2cc2f0cc45d5d6d8b411
2015-01-16 16:06:27 +01:00
Christian Berendt 713b745e0e Enable PEP8 checks for F401, E202, E271, E272, E711, E712
* F401 module imported but unused
* E271 multiple spaces after keyword
* E272 multiple spaces before keyword
* E202 remove extraneous whitespace
* E711 comparison to None should be 'if cond is None:'
* E712 comparison to True/False should be 'if cond is True/False:' or 'if cond:'

Change-Id: I56a1dbee2ae17b8315a55215e2c676e0de8311f7
2015-01-16 13:11:31 +01:00
Christian Berendt b148189d18 Enable PEP8 checks for E121, E129, E231, E265, E302
* E121 continuation line under-indented for hanging indent
* E129 visually indented line with same indent as next logical line
* E302 expected 2 blank lines, found x
* E231 missing whitespace after ','
* E265 block comment should start with '# '

Change-Id: If22172e8a60e962ddbf43db01e7633c60af0a1bc
2015-01-09 13:42:13 +01:00
Christian Berendt 05a27ebb9c Enable PEP8 checks for E211, E222, E225, E228
* E211 whitespace before '('
* E222 multiple spaces after operator
* E225 missing whitespace around operator
* E228 missing whitespace around modulo operator

Change-Id: I19f51d646bbb9a8854555419a4139c059207ea60
2015-01-09 08:50:47 +01:00
Christian Berendt 917d2af7d8 Use flake8 and hacking instead of pep8 for Python syntax checks
All new findings of flake8 and hacking are ignored for the moment
to only change the used tool with this change. Ignored checks should
be enabled in the future.

Change-Id: I041f7d1427b897692506b2041b8cc50a40d97cc5
2014-12-23 07:29:14 +00:00
Christian Berendt c470c4229f Check packstack/version.py for PEP8 issues
Change-Id: If7666db19a2a37c5fb55ad54570cc68c9a9b2ceb
2014-12-01 12:01:05 +01:00
Monty Taylor de7e1d5507 Add docs environment to tox.ini
As per the governance resolution https://review.openstack.org/119875,
projects should have a docs environment in their tox.ini testing
interface. Add one.

Change-Id: I15c78a3c208820f041c9c3fa957aeb03eb7ab398
2014-09-08 13:51:37 -07:00
Martin Magr 3d92f24ccc Plugins refactor
- Replaced CONFIG_<OS-component>_HOST(S) parameters for CONFIG_CONTROLLER_HOST,
  CONFIG_COMPUTE_HOSTS and CONFIG_NETWORK_HOSTS to minimize count of potential
  deployment architecture to maintainable level
- Unified coding style in plugins, PEP8-tized and forced pep8 check on them

Implements: blueprint simplification

Change-Id: I597f209b62d8d0c3709bb446cb33c804509eef9f
2014-05-22 10:54:21 +02:00
Derek Higgins b3554a226c Adding files to pep8 tests
Change-Id: I96bfed7541aa96e243950b3bcc896e9fe17471ba
2013-04-23 07:52:22 -04:00
Derek Higgins e49a1fb18b The operatingsystem fact on Fedora begins in a uppercase F
The error being thrown by this on Fedora was being silently ignored
added regex for this
Also adding adding a unit test for this
Adding the effected module to pep8 tests

Change-Id: I4e4d72e6de0bce597474434a4e18112f79913718
2013-01-25 06:06:15 -05:00
Derek Higgins 607acaf857 Creating a single unit and pep8 test
Starting with one of each to make sure the unit and pep8 gate tests work

Change-Id: Ia4e5595df8937c8612143e19e21e17cfdc18a4b1
2013-01-12 23:06:40 +00:00