openstack
/
patrole
Code Issues Proposed changes

Move virtual interfaces test into misc policy actions file 

Move test_list_virtual_interfaces into
test_server_misc_policy_actions_rbac.py to further increase gate
stability and decrease gate run time.

The number of calls to create_test_server() should be minimized
for RBAC testing because we don't do too much modification to the
resources that are created -- only what's necessary to trigger the
API action corresponding to the RBAC policy under test. Further,
minimizing such calls reduces the risk of spinning up too many servers
concurrently in our gates: the source of various gate failures as
limited resources lead to server faults being raised.

Change-Id: I1ff0c14e741c8907f2f23a4dd63705713f06d337
Partial-Bug: #1699415
This commit is contained in:
Felipe Monteiro 2017-07-05 16:33:03 +01:00
parent 2bf66db706
commit d98273152a
2 changed files with 21 additions and 41 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

21
patrole_tempest_plugin/tests/api/compute/test_server_misc_policy_actions_rbac.py
View File

@ -394,3 +394,24 @@ class MiscPolicyActionsNetworkRbacTest(rbac_base.BaseV2ComputeRbacTest):
self.rbac_utils.switch_role(self, toggle_rbac_role=True)
self.servers_client.add_fixed_ip(self.server['id'],
networkId=network_id)
@rbac_rule_validation.action(
service="nova",
rule="os_compute_api:os-virtual-interfaces")
@decorators.idempotent_id('fc719ae3-0f73-4689-8378-1b841f0f2818')
def test_list_virtual_interfaces(self):
"""Test list virtual interfaces, part of os-virtual-interfaces.
If Neutron is available, then call the API and expect it to fail
with a 400 BadRequest (policy enforcement is done before that happens).
For more information, see:
https://developer.openstack.org/api-ref/compute/#servers-virtual-interfaces-servers-os-virtual-interfaces-deprecated
"""
self.rbac_utils.switch_role(self, toggle_rbac_role=True)
if CONF.service_available.neutron:
msg = "Listing virtual interfaces is not supported by this cloud."
with self.assertRaisesRegex(lib_exc.BadRequest, msg):
self.servers_client.list_virtual_interfaces(self.server['id'])
else:
self.servers_client.list_virtual_interfaces(self.server['id'])

41
patrole_tempest_plugin/tests/api/compute/test_server_virtual_interfaces_rbac.py
View File

@ -1,41 +0,0 @@
# Copyright 2017 AT&T Corporation.
# All Rights Reserved.
#
# Licensed under the Apache License, Version 2.0 (the "License"); you may
# not use this file except in compliance with the License. You may obtain
# a copy of the License at
#
# http://www.apache.org/licenses/LICENSE-2.0
#
# Unless required by applicable law or agreed to in writing, software
# distributed under the License is distributed on an "AS IS" BASIS, WITHOUT
# WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the
# License for the specific language governing permissions and limitations
# under the License.
from tempest import config
from tempest.lib import decorators
from tempest.lib import exceptions
from patrole_tempest_plugin import rbac_rule_validation
from patrole_tempest_plugin.tests.api.compute import rbac_base as base
CONF = config.CONF
class ServerVirtualInterfacesRbacTest(base.BaseV2ComputeRbacTest):
@rbac_rule_validation.action(
service="nova",
rule="os_compute_api:os-virtual-interfaces")
@decorators.idempotent_id('fc719ae3-0f73-4689-8378-1b841f0f2818')
def test_list_virtual_interfaces(self):
server = self.create_test_server(wait_until='ACTIVE')
self.rbac_utils.switch_role(self, toggle_rbac_role=True)
if CONF.service_available.neutron:
msg = "Listing virtual interfaces is not supported by this cloud."
with self.assertRaisesRegex(exceptions.BadRequest, msg):
self.servers_client.list_virtual_interfaces(server['id'])
else:
self.servers_client.list_virtual_interfaces(server['id'])