Fix unit tests that mock python ssl module

Change-Id: I714f18beba6466398cc96b78c5ef33528a2bdfd7
This commit is contained in:
Isaac Mungai 2016-10-03 17:10:29 -04:00
parent 60c0efdc57
commit 8b9d771df0
1 changed files with 7 additions and 31 deletions

View File

@ -34,12 +34,8 @@ class TestAkamaiUtils(base.TestCase):
self.mock_ssl_crypto = ssl_crypto_patcher.start()
self.addCleanup(ssl_crypto_patcher.stop)
ssl_context_patcher = mock.patch('ssl.create_default_context')
self.mock_ssl_context = ssl_context_patcher.start()
self.addCleanup(ssl_context_patcher.stop)
context_patcher = mock.patch('ssl.SSLContext')
self.mock_context = context_patcher.start()
self.mock_ssl_context = context_patcher.start()
self.addCleanup(context_patcher.stop)
self.mock_ssl_context.return_value.wrap_socket.return_value. \
@ -178,32 +174,12 @@ class TestAkamaiUtils(base.TestCase):
self.assertRaises(ValueError, utils.get_sans_by_host, 'remote_host')
def test_default_context_error(self):
self.mock_ssl_context.side_effect = AttributeError(
'Mock -- Something went wrong create default context.'
)
self.mock_context.return_value.wrap_socket.return_value. \
getpeercert.return_value = {
'issuer': (
(('countryName', 'IL'),),
(('organizationName', 'Issuer Ltd.'),),
(('organizationalUnitName', 'Secure Cert Signing'),),
(('commonName', 'Secure CA'),)
),
'notAfter': 'Nov 22 08:15:19 2013 GMT',
'notBefore': 'Nov 21 03:09:52 2011 GMT',
'serialNumber': 'DEAD',
'subject': (
(('description', 'Some-DESCRIPTION'),),
(('countryName', 'US'),),
(('stateOrProvinceName', 'Georgia'),),
(('localityName', 'Atlanta'),),
(('organizationName', 'R_Host, Inc.'),),
(('commonName', '*.r_host'),),
(('emailAddress', 'host_master@r_host'),)
),
'subjectAltName': (('DNS', '*.r_host'), ('DNS', 'r_host')),
'version': 3
}
self.mock_ssl_context.side_effect = [
AttributeError(
'Mock -- Something went wrong create default context.'
),
self.mock_ssl_context()
]
self.assertEqual(
2, utils.get_ssl_number_of_hosts_alternate('remote_host'))