openstack
/
project-team-guide
Code Issues Proposed changes

Review guide: clarify 2x +2 policies 

Make it clear that individual teams are free to set their own policies
on how many +2 votes are required to approve a patch, and that core
reviewers should confirm the policy of the project they're reviewing.

Change-Id: Icb2406ef2b4fbd81d1f73ee6efa30a6ca7ea4f14
This commit is contained in:
Zane Bitter 2018-09-14 11:55:47 -06:00
parent b6c0925f1f
commit ef975a6cda
1 changed files with 11 additions and 10 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

21
doc/source/review-the-openstack-way.rst
View File

@ -21,17 +21,18 @@ code review process.
Code Review +2
==============
The +2 vote is only available to core reviewers. In general, two +2 votes are
required before a change can be merged, although some projects relax the
requirements in certain circumstances, such as trivial changes. Confusingly,
two +1s do not equal a +2!
The +2 vote is only available to core reviewers. Projects are encouraged to
require two +2 votes before a change can be merged, although some projects only
require a single +2, and many relax the requirements in certain circumstances
(such as trivial changes). If you are a core reviewer, check your local
policies. Confusingly, two +1s do not equal a +2!
Voting +2 indicates that you're happy for another core reviewer to Approve the
change. If another core reviewer has already voted +2 then you would generally
Approve the change at the same time. However, you might hold off on approval to
give the author or another reviewer the chance to respond to some trivial
feedback if they think it appropriate. If the feedback is sufficiently trivial,
this is preferable to only voting +1.
Voting +2 without Approving indicates that you're happy for another core
reviewer to Approve the change. If another core reviewer has already voted +2
then you would generally Approve the change at the same time. However, you
might hold off on approval to give the author or another reviewer the chance to
respond to some trivial feedback if they think it appropriate. If the feedback
is sufficiently trivial, this is preferable to only voting +1.
If another core reviewer had previously voted +2 on an earlier patch set, and
the patch has only changed in trivial ways that you're sure they would be happy