Commit Graph

284 Commits

Author SHA1 Message Date
Takashi Kajinami 013f2122bc validate maxdelay for cron job
The parameter descriptions says the value should be a positive integer
(or 0). Validate the given value to reject invalid values such as
strings or even negative values.

Change-Id: Ib9f90c88f564ac5a0d545f955257741290998a5e
2024-04-08 16:41:07 +09:00
Zuul 4ce5025534 Merge "Expose rabbit_transient_quorum_queue" 2024-03-14 18:08:35 +00:00
Takashi Kajinami 06ff4862ca Expose rabbit_transient_quorum_queue
Depends-on: https://review.opendev.org/911021
Change-Id: I363931363160fb4a51307e1c789a776563ec0cd8
2024-03-13 02:30:17 +09:00
Takashi Kajinami b3016e3bf3 Stop hard-coding config file for db sync
The aodh-dbsync command by default loads /etc/aodh/aodh.conf. Removing
the override allows us to use additional paths such as aodh.conf.d in
the future.

Change-Id: Ic3bf121611d7221209c006872ab98b0682aa2273
2024-03-05 03:24:59 +00:00
Takashi Kajinami 9d14c5f8e1 healthcheck: Expose ignore_proxied_requests parameter
Depends-on: https://review.opendev.org/909807
Change-Id: Ifb42750a7767579bb31f79a68f4042c8f6e8caa1
2024-02-22 03:04:40 +00:00
Zuul 7cd26de684 Merge "Fix notification related to api service" 2024-02-21 18:35:47 +00:00
Takashi Kajinami 1bb8220432 Ensure authtoken installs python-memcached before services start
The keystone::resources::authtoken defined resource type installs
python-memcached, which should be available when services start.

This ensures that all configuration and package installation for
authtoken middleware are completed before config step completes, to
ensure that requirement.

Change-Id: I8f2df1c5881473ca7937bdb26954ce566569788a
2024-02-17 21:22:24 +09:00
Takashi Kajinami 21361a4e21 Fix notification related to api service
This is follow-up of fb448c80b5 and
fixes notifications to restart api service, which is currently broken
for standalone api service.

Change-Id: Ic907f3c59bb8a1174ff0d64a85faa7041d02298e
2024-02-17 14:47:48 +09:00
Zuul 4d1bb57b75 Merge "Refactor resource dependencies" 2024-02-16 16:09:55 +00:00
Takashi Kajinami fb448c80b5 Refactor resource dependencies
This refactors resource dependencies to improve the following points.

 - Avoid unnecessary dependencies across services. For example aodh
   service does not require cinder db.

 - Restart only api service when config files like paste.ini, which
   are used only be api service is changed.

Change-Id: Ie9922c101e7981801c4c8c8753f0ce54ac8e5fe3
2024-01-31 01:07:57 +00:00
Takashi Kajinami 0acf300e12 Add support for oslo.reports options
Depends-on: https://review.opendev.org/804804
Change-Id: I3ed546597f3db58919e0c0a195025022bc00f6e2
2024-01-29 12:16:25 +09:00
Takashi Kajinami 39d3dcc438 healthcheck: Expose allowed_source_ranges
... which was added to puppet-oslo recently.

Depends-on: https://review.opendev.org/905557
Change-Id: I28bfa93296cf1a1cb2f69da3e92ad86d64b08ab5
2024-01-17 02:50:43 +09:00
Takashi Kajinami c93a1be851 Use new openstackclient tag
The new openstackclient tag was added so that we can get all resources
about openstack CLI more easily. This adds this tag to aodhclient
because the package provides some sub-commands.

Change-Id: Iaa9e1b818e8cb337e41688dc956a17193656ed3e
2023-11-20 01:11:17 +09:00
Zuul ea04b9980c Merge "RabbitMQ: Add support for quorum queue options" 2023-09-15 16:09:32 +00:00
Takashi Kajinami 193d0e6cd2 RabbitMQ: Add support for quorum queue options
Depends-on: https://review.opendev.org/894866
Change-Id: I644af1c7d7f4721b200fc0b771ad84609e2eb4b6
2023-09-14 10:42:33 +09:00
Zuul 827d05b2f8 Merge "Do not restart services after policy file changes" 2023-09-11 03:41:08 +00:00
Takashi Kajinami 5e9c6de5aa Ensure purge_config takes a boolean value
The purge_config parameters only accept boolean values. This enforces
that using the typed parameters.

Change-Id: I1c48571be9068aa428bba38d99956a0f534888b9
2023-07-13 22:09:14 +09:00
Takashi Kajinami f87f4629c1 Do not restart services after policy file changes
The oslo.policy library has implementations to detect change in policy
rules and reload the new rules without service restart.

Change-Id: Ie2ef0bd7f9b4ab7f60a976fe7832f49b288eca64
2023-07-13 11:54:46 +09:00
Zuul fd5058341b Merge "Add per module policy service refresh" 2023-06-26 15:26:17 +00:00
Zuul 0827e06a1d Merge "authtoken: Make password required" 2023-06-25 22:52:10 +00:00
Tobias Urdin 366abb9ccd Add per module policy service refresh
Updating the policies for this project should only
refresh the services that reads it.

Change-Id: I7dc9f4a9849043624359eb97775af20d1885103a
2023-06-26 00:03:15 +02:00
Takashi Kajinami 8584eeb517 authtoken: Make password required
The password parameter is not really optional. This makes it
a required parameter to give more sensible validation error.

Change-Id: I77001fb010d5ec276cba1761e022f0037716bfa5
2023-06-23 10:21:44 +09:00
Takashi Kajinami aa72e6bb13 Validate status of cron resource
This makes sure that the supported value is used for the parameters
which determine the ensure property of a cron resource type.

Change-Id: I8b87eef335274e2607b9d7fd1bf514648fc9e580
2023-06-22 16:18:20 +09:00
Takashi Kajinami c4ab7eb22a replace validate_legacy with proper data types
the validate_legacy function is marked for deprecation in
v9.0.0 from puppetlabs-stdlib.

Change-Id: I6a4e4fe824713a08839ab49f151415a9186a9a5a
2023-06-16 02:02:59 +09:00
Takashi Kajinami bea839fe5a Add strict validation about boolean parameters
This ensures the parameters used by if-else logic accept only boolean
values because non-boolean can result in unexpected behavior.

Change-Id: I73444acddba8818dfcee5d2b2bca52c7e4cf3451
2023-03-03 04:37:10 +00:00
Takashi Kajinami 3bf38f8403 Replace legacy facts and use fact hash
... because the latest lint no longer allows usage of legacy facts and
top scope fact.

Change-Id: I2a52329948becfcfb799f034847db9eae7bd903d
2023-03-01 16:47:43 +09:00
Takashi Kajinami df3fce9e6b Expose policy_default_rule
The option has been managed by the underlying puppet-oslo module but
has not been configurable. This introduces the parameter to customize
the option.

Change-Id: I8c02a3651cf6a749e1039b0a3a9b92800fb4a79e
2023-01-23 14:27:43 +09:00
Takashi Kajinami 551bf848e1 Remove cleanup of [DEFAULT] evaluation_interval
This logic was added during the previous cycle by [1].

This old parameter should be removed when a deployment is upgraded to
Zed, thus we no longer need this cleanup beyond Zed.

[1] c58c36d927

Change-Id: Ic791e5b597d4b702241d7938ed8d0c0f37f2e7ff
2022-11-18 11:19:45 +09:00
Takashi Kajinami 86d8f81e0d Use standard parameter description format for wsgi::apache
Currently parameter description of the <module>::wsgi::apache classes
are formatted differently in individual modules, and this is making
the maintenance effort quite difficult.

This change updates the description format following the srandard one
we are globally using in our modules to reduce undesired differences
between modules.

Change-Id: Ie874d47e7c9c37da642c2cc5d9c46e385e7cc176
2022-08-26 15:31:17 +09:00
Takashi Kajinami c8c59f1e9a Add Apache WSGI logging parameters for pipe/syslog
Add parameters for advanced logging configurations in Apache to
support piped logging and support for syslog (via mod_syslog
available in Apache >= 2.5.0)

Co-Authored-By: Andy Botting <andy@andybotting.com>
Change-Id: I16c7a6407d647a25d6093239b30845a212202a5c
2022-08-26 14:31:43 +09:00
Zuul c64f4251c5 Merge "Remove deprecated aodh::evaluator::coordination_url" 2022-08-12 08:10:07 +00:00
Zuul 99307d1bf1 Merge "Adapt to new type validation in puppetlabs-apache" 2022-08-08 19:25:54 +00:00
Takashi Kajinami 97682cfa99 Remove deprecated aodh::evaluator::coordination_url
... because it was deprecated during Xena cycle[1] in favor of the new
aodh::coordination class.

[1] 16091c8dd6

Change-Id: I0e11987c7d121b2fb639274ed60181c56ce4f6d1
2022-08-05 01:15:54 +09:00
Takashi Kajinami 976196bce3 Adapt to new type validation in puppetlabs-apache
The puppetlabs-apache module is enforcing more strict data type
validation[1].

This change updates the default values to adapt to that change.

[1] f41251e336

Closes-Bug: #1983300
Depends-on: https://review.opendev.org/851652
Change-Id: I9261c53fdb930fd9ff5e2c06e91eb312d665bb9a
2022-08-02 14:38:30 +09:00
Takashi Kajinami 0c8d02c758 Expose headers option of apache::vhost
The headers option in apache::vhost is required in some case, for
example when adding the X-XSS-Protection header. This change allows
customizing the option for the api vhost.

This change also adds support for request_headers so that both request
headers and response headers can customized.

Change-Id: I857407802617087f75334c8357055250dcd4cef5
2022-06-30 08:20:42 +09:00
Rajesh Tailor 8b29e4b5ab Fix typos in parameter descriptions
Change-Id: I643cc6b6cc85c1c3fc9d4803ebbf56ed1c40da5c
2022-06-17 13:02:21 +05:30
Takashi Kajinami c58c36d927 Update section of the evaluation_interval parameter
The evaluation_interval parameter in the [DEFAULT] section has been
deprecated and it was migrated to the [evaluator] section.

This change updates the parameter section accordingly.

Depends-on: https://review.opendev.org/837864
Change-Id: If41e9e21771ea236ec18379790fe5427dcb6e8af
2022-06-13 17:08:13 +09:00
Takashi Kajinami cc2cec0491 coordination: Remove deprecated heartbeat
The parameter was deprecated during Yoga cycle[1] in favor of the new
heartbeat_interval parameter.

[1] 49eb825204

Change-Id: I03d217663445001fc48f9192774ae6b680d2d7f9
2022-05-20 00:33:03 +09:00
Takashi Kajinami 4ec7119fc6 apache+mod_wsgi: Disable SSL by default
During the previous cycle, a warning message was added to inform users
of this change.

Now the default value is updated so that SSL is disabled by default.

Change-Id: I0f05258885570637aa9d53b2d6a69c1756f375e9
2022-05-06 20:35:57 +09:00
Takashi Kajinami 9400853421 listener: Add support for tunable parameters
Change-Id: Iaa9199dde153cfd218171a0b23c724bad421529c
2022-04-13 11:24:09 +09:00
Takashi Kajinami 442e6965ed Globally support system scope credentials
After spending huge effort to understand the exact requirements to
enforce SRBAC, we learned it's very difficult to find the required
scope in each credential. This requires understanding implementation of
client-side as well as server-side, and requirement might be different
according to the deployment architecture or features used.

Instead of implementing support based on the actual implementation,
this introduces support for system scope credentials to all places
where keystone user credential is defined, and make all credential
configurations consistent.

Change-Id: I28ff22b43ea5938056082361c9d0c98f89de1a03
2022-03-04 01:15:53 +09:00
Zuul 6d56d688e3 Merge "Avoid hard-coding OS user/group in each manifest" 2022-02-22 16:38:47 +00:00
Zuul 0f0fcf4661 Merge "Drop unused implementation to expect "undef"" 2022-02-20 11:53:01 +00:00
Takashi Kajinami 6675988bbb Avoid hard-coding OS user/group in each manifest
and replace hard-codes by definition in params.pp .

Change-Id: Ie9c96fed2e902722067cf41398d49959059a0721
2022-02-20 19:51:14 +09:00
Zuul e472146062 Merge "Remove deprecated amqp_allow_insecure_clients" 2022-02-18 10:03:32 +00:00
Takashi Kajinami 606e4ada38 Avoid accessing undefined variable
Change-Id: I413a7040a8e8af7dc44ef08f5116ad8f8c900eed
2022-02-10 13:19:11 +09:00
Takashi Kajinami 7b33c0c74e Remove deprecated amqp_allow_insecure_clients
... because it was deprecated during Wallaby cycle.

Change-Id: Ia8422e02d23e1e5c4c5dc530042f1b9e9a020c9a
2022-02-08 21:53:58 +09:00
Zuul 7f91fe0769 Merge "Simplify definition to ensure keystone resource creation" 2022-02-07 16:24:13 +00:00
Takashi Kajinami 1b70d0c380 Simplify definition to ensure keystone resource creation
Use the whole resource type instead of its individual resources, to
rely on interface instead of implementation of the dependent module.

Change-Id: Ie36c8a096c33a475b21a1dc02a04de49d35be9c9
2022-02-06 16:58:03 +09:00
Takashi Kajinami 2bf346a6dd Use generated script instead of app.wsgi
Change-Id: I0dd1bf37160e76856d8055e033aa0d0c3ca4a244
2022-02-04 09:16:04 +09:00