The aodh-dbsync command by default loads /etc/aodh/aodh.conf. Removing
the override allows us to use additional paths such as aodh.conf.d in
the future.
Change-Id: Ic3bf121611d7221209c006872ab98b0682aa2273
This refactors resource dependencies to improve the following points.
- Avoid unnecessary dependencies across services. For example aodh
service does not require cinder db.
- Restart only api service when config files like paste.ini, which
are used only be api service is changed.
Change-Id: Ie9922c101e7981801c4c8c8753f0ce54ac8e5fe3
The new openstackclient tag was added so that we can get all resources
about openstack CLI more easily. This adds this tag to aodhclient
because the package provides some sub-commands.
Change-Id: Iaa9e1b818e8cb337e41688dc956a17193656ed3e
Recent update in rspec-puppet removed some of the config interfaces for
old puppet versions[1]. This drops usage of these interfaces to resolve
the following error in unit tests.
```
An error occurred while loading ./spec/unit/provider/manila_spec.rb.
Failure/Error: c.manifest_dir = File.join(fixture_path, 'manifests')
NoMethodError:
undefined method `manifest_dir='...
```
[1] 316d95923c
Change-Id: I7198659909294242c3a0d524abdaab422cee7b65
The option has been managed by the underlying puppet-oslo module but
has not been configurable. This introduces the parameter to customize
the option.
Change-Id: I8c02a3651cf6a749e1039b0a3a9b92800fb4a79e
Add parameters for advanced logging configurations in Apache to
support piped logging and support for syslog (via mod_syslog
available in Apache >= 2.5.0)
Co-Authored-By: Andy Botting <andy@andybotting.com>
Change-Id: I16c7a6407d647a25d6093239b30845a212202a5c
... because it was deprecated during Xena cycle[1] in favor of the new
aodh::coordination class.
[1] 16091c8dd6
Change-Id: I0e11987c7d121b2fb639274ed60181c56ce4f6d1
The puppetlabs-apache module is enforcing more strict data type
validation[1].
This change updates the default values to adapt to that change.
[1] f41251e336
Closes-Bug: #1983300
Depends-on: https://review.opendev.org/851652
Change-Id: I9261c53fdb930fd9ff5e2c06e91eb312d665bb9a
This reverts commit 0f1d26cdb6.
Reason for revert:
puppet-postgresql 8.1.0 was released and now the module supports RHEL 9
(and CentOS 9 effectively).
Note:
This change adds the service_provider fact in test fact data because
it is required by puppet-postgresql.
Depends-on: https://review.opendev.org/850705
Change-Id: Id71237bc97e04f6c83403f60605d3bff44bc944a
The value with a white space should be accepted instead of being
rejected. This change fixes the wrong test case description and makes
sure the description explains what is actually tested.
Change-Id: I15addb494305b5576bc9a19078ededf962bc0dd7
The headers option in apache::vhost is required in some case, for
example when adding the X-XSS-Protection header. This change allows
customizing the option for the api vhost.
This change also adds support for request_headers so that both request
headers and response headers can customized.
Change-Id: I857407802617087f75334c8357055250dcd4cef5
The evaluation_interval parameter in the [DEFAULT] section has been
deprecated and it was migrated to the [evaluator] section.
This change updates the parameter section accordingly.
Depends-on: https://review.opendev.org/837864
Change-Id: If41e9e21771ea236ec18379790fe5427dcb6e8af
During the previous cycle, a warning message was added to inform users
of this change.
Now the default value is updated so that SSL is disabled by default.
Change-Id: I0f05258885570637aa9d53b2d6a69c1756f375e9
After spending huge effort to understand the exact requirements to
enforce SRBAC, we learned it's very difficult to find the required
scope in each credential. This requires understanding implementation of
client-side as well as server-side, and requirement might be different
according to the deployment architecture or features used.
Instead of implementing support based on the actual implementation,
this introduces support for system scope credentials to all places
where keystone user credential is defined, and make all credential
configurations consistent.
Change-Id: I28ff22b43ea5938056082361c9d0c98f89de1a03
The puppt-postgresql module does not support CentOS 9 yet and requires
some version parameters to be run on CentOS 9. This change disables
unit tests requiring that module, until the module supports CentOS 9.
Change-Id: I8b3d2308689bbb5453c4f2762bf67c3ba3624f1a
The aodh-expirer command expects the target database is already
initialized. This change ensures db sync is completed before cron job
is enabled.
Closes-Bug #1955829
Change-Id: Ieff011ca2bd415d25df227fb7287c0878ec72220
This is follow-up of c0075580a5 and
removes the remaining unit test case to ensure the apache class is
included, because the class is no longer included directly.
Change-Id: I0ba813e637689004f03699426f2ec637e93e5010
This change refactors how the dependent libraries are loaded during
unit tests, and load the libraries in the base spec_helper to avoid
duplicate and redundant implementations.
Change-Id: I91357ee3ac39a42b64304c7d9cd585a6be308184
This change removes direct reference to some classes in
puppetlabs-apache. Details are explained below.
- The api class doesn't need access to anything defined in
apache::params
- The following classes are included by the openstacklib::wsgi::apache
resource type, and current inclusions are just redundant.
Change-Id: Ie0c61d21b5a64210c79765dc3ebd3c39d4d98c5d
This change is the first step to support secure RBAC and allows usage
of system scope credentials for Keystone API request.
This change covers the following two items.
- assignment of system scope roles to system user
- credential parameters for authtoken middleware
Depends-on: https://review.opendev.org/804325
Change-Id: I672a988e77e58df0addb1ed4a47d609cbcef1331
Currently all packages are defined using ensure_resource but it is
redundant because we don't expect these aodh packages are managed
outside of puppet-aodh. This replaces usage of ensure_resource by
the normal package resource, to make implementations more simple.
Change-Id: I0a92669b2f9a41e10a49c7db0865343453045c7b