openstack
/
puppet-ceph
Code Issues Proposed changes

Merge "Use validate_legacy"

This commit is contained in:
Zuul 2019-02-27 04:38:19 +00:00 committed by Gerrit Code Review
parent 8df92d51d3 e94c1072af
commit 678c48a065
2 changed files with 3 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
manifests/profile/params.pp
View File

@ -240,7 +240,8 @@ class ceph::profile::params (
$fs_name = undef,
$rbd_default_features = undef,
) {
validate_hash($client_keys)
validate_legacy(Hash, 'validate_hash', $client_keys)
if $authentication_type == 'cephx' and empty($client_keys) {
fail("client_keys must be provided when using authentication_type = 'cephx'")

2
spec/classes/ceph_profile_params_spec.rb
View File

@ -28,7 +28,7 @@ describe 'ceph::profile::params' do
}"
end
it { should raise_error Puppet::Error, /is not a Hash/ }
it { should raise_error(Puppet::Error) }
end
describe "should fail when using cephx without client_keys" do