The rbd_ceph_conf parameter accepts a valid path for *.conf file,
because of the internal logic to detect the cluster name.
Change-Id: Ia42f5db1ff701b5ba90dbdb7e80c7b906b406222
We can accept config change unless we backport the change, because
services need to be restarted anyway during upgrade.
Change-Id: Ibb49c49f85f0c5bee8545e240fe3c6aac7e3d13b
... to each driver configurations, so that users can customize this
option in individual driver sections.
Note that this option works only when the driver supports thin
provisioning.
Change-Id: I3da6dd142c2ae5967da09787f01cd39052f14f42
This defined resource type was overlooked when the reserved_percentage
option was added[1].
[1] 5451b7135b
Change-Id: I602f47cb06eff1c41b47abe36853bc418a122332
This refactors resource dependencies to improve the following points.
- Avoid unnecessary dependencies across services. For example aodh
service does not require cinder db.
- Restart only api service when config files like paste.ini, which
are used only be api service is changed.
Change-Id: I3953eea75f00c44363870c318f960b7299c65e7c
This configuration is not actually needed because the rbd driver has
the specific rbd_user option to pick up the appropriate user.
Change-Id: Ie9e517845c115a2f0a45c8682c68c611c151d231
The option defaults to False, so we don't need the explicit default and
can replace it by os_service_default fact.
Change-Id: I1425802e4047f1bb79c90a1567bd512696dc5a2d
This introduces support for the options used by the deferred deletion
feature[1].
[1] c6580b2ab4ba10fefddf790a9282d1201df782f1
Change-Id: Ia385f88f1a9cdf79ca912844ff773fbc3e3fd688
The use_chap_auth option defaults to false in cinder, so we don't have
to explicitly define the same default.
Change-Id: I978749f078f7bd69e611f8b18546deb248435298
This introduces support for the options to customize the image volume
cache feature. This feature is added to the default class as well as
the defined resource type for each volume driver, so that users can
configure the global options as well as the backend specific options.
Note that rbd driver and vmware driver are intentionally excluded,
because for these drivers the specific image store drivers are more
popular method to use in-storage copy when creating a volume from
an image.
Change-Id: I09480346f3a2f05b5ab0aad7033f1b37a31648db
The volume_backend_name property in volume types should be set
according to the volume_backend_name option, instead of the backend
config section name.
This change ensures the option value is used consistently among all
defined resource types to manage volume backend options.
Change-Id: I29c5bcdb0e79f6f98d272995de6a86a0062cea48
This fixes the regex to validate the properties property so that value
strings shorter than 3 characters are accepted.
This also removes the heading spaces because these are not stripped but
added to the keys, which likely results in an unexpected result.
Change-Id: I8d703a48060abb61834ecec9c72bb6295eff2b81
We have to ensure cinder services are up before the quota command is
executed, because the command needs access to cinder API.
Change-Id: I44ae2f5628283818a7aa4e20b823808e30b559c7
This looses dependency using the new openstackclient tag, which
requires only packages actually related to openstack CLI.
Also, cinderclient is not required by cinder itself so the support
package tag can be removed.
Depends-on: https://review.opendev.org/899594
Change-Id: Ieb7656f1f9a48086a13ebeb9c5418e800bed790f
Using credentials in keystone_authtoken options for cinder_* resources
was deprecated some cycles ago[1].
[1] 596a77483b
Change-Id: I21fc46f49a143ae1282cad91732925195eda6541
Some of the volume drivers support the reserved_percentage option which
determines the minimum free percentage kept. This introduces support
for this option.
Although the option is defined in the base volume driver class, it has
effect only in drivers with appropriate implementations.
Change-Id: I6060daab9fd72f96084b3d0c5cc5783da7f5c64c
Parameters types is better way to enforce specific values because it's
implemented at the interface level.
This offloads some of the validations we have in manifest logics
because we already started using parameter types.
Change-Id: I93f1bdae811a999bbbc55861d9e2c7500d347c22
The powermax_port_groups option accepts a comma-separated list with
bounds. This allows users to use an array value to define the value
used for this option. Now the logic adds bounds ([]) in case a string
value is given but the value does not contain bounds.
Change-Id: I9b747509f7e13b05a1c0e1096733f7beb477033f
... instead of leaving the option unmanaged.
This also removes the reference in default definitions from the defined
resource type to the params class, which does not work if the params
class is not explicitly included in advance.
Unit tests coverage is also improved to ensure both default parameters
and customized parameters work.
Change-Id: I0b8199a27377a7d035f882586979a678b061e5da
Recent update in rspec-puppet removed some of the config interfaces for
old puppet versions[1]. This drops usage of these interfaces to resolve
the following error in unit tests.
```
An error occurred while loading ./spec/unit/provider/manila_spec.rb.
Failure/Error: c.manifest_dir = File.join(fixture_path, 'manifests')
NoMethodError:
undefined method `manifest_dir='...
```
This also removes explicit setting of mock module. The definition is
no longer required since we bumped puppetlabs_spec_helper to v 5.0.0.
[1] 316d95923c
Change-Id: I4d44a4beb67209c7c7806400cc9b83f6d24ca442
This parameter was supposed to be required but actually it was not.
Without this parameter given, nfs driver may be configured without any
actual backend.
This updates the parameter definition to make the parameter actually
required.
Change-Id: I1c87dc4119dec56c78638afbbd5a650eeafbda3e
This fixes the missing inclusion of cinder::params, to ensure
the subsequent reference works properly.
Change-Id: Idca647a1c149d93f3c477ac448ddc69ac5bbb2b1
Tobias Urdin