openstack
/
puppet-freezer
Code Issues Proposed changes

Merge "Remove redundantly tested code"

This commit is contained in:
Zuul 2019-01-18 23:48:05 +00:00 committed by Gerrit Code Review
parent 2a6342ab79 2958186767
commit b7734515e6
1 changed files with 6 additions and 68 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

74
spec/classes/freezer_db_spec.rb
View File

@ -1,10 +1,9 @@
require 'spec_helper'
describe 'freezer::db' do
shared_examples 'freezer::db' do
context 'with default parameters' do
it { is_expected.to contain_oslo__db('freezer_config').with(
it { should contain_oslo__db('freezer_config').with(
:db_max_retries => '<SERVICE DEFAULT>',
:connection => 'sqlite:////var/lib/freezer/freezer.sqlite',
:idle_timeout => '<SERVICE DEFAULT>',
@ -19,7 +18,8 @@ describe 'freezer::db' do
context 'with specific parameters' do
let :params do
{ :database_connection => 'mysql+pymysql://freezer:freezer@localhost/freezer',
{
:database_connection => 'mysql+pymysql://freezer:freezer@localhost/freezer',
:database_idle_timeout => '3601',
:database_min_pool_size => '2',
:database_db_max_retries => '-1',
@ -31,7 +31,7 @@ describe 'freezer::db' do
}
end
it { is_expected.to contain_oslo__db('freezer_config').with(
it { should contain_oslo__db('freezer_config').with(
:db_max_retries => '-1',
:connection => 'mysql+pymysql://freezer:freezer@localhost/freezer',
:idle_timeout => '3601',
@ -43,79 +43,17 @@ describe 'freezer::db' do
:pool_timeout => '21',
)}
end
context 'with postgresql backend' do
let :params do
{ :database_connection => 'postgresql://freezer:freezer@localhost/freezer', }
end
it 'install the proper backend package' do
is_expected.to contain_package('python-psycopg2').with(:ensure => 'present')
end
end
context 'with MySQL-python library as backend package' do
let :params do
{ :database_connection => 'mysql://freezer:freezer@localhost/freezer', }
end
it { is_expected.to contain_package('python-mysqldb').with(:ensure => 'present') }
end
context 'with incorrect database_connection string' do
let :params do
{ :database_connection => 'foodb://freezer:freezer@localhost/freezer', }
end
it_raises 'a Puppet::Error', /validate_re/
end
context 'with incorrect pymysql database_connection string' do
let :params do
{ :database_connection => 'foo+pymysql://freezer:freezer@localhost/freezer', }
end
it_raises 'a Puppet::Error', /validate_re/
end
end
shared_examples_for 'freezer::db on Debian' do
context 'using pymysql driver' do
let :params do
{ :database_connection => 'mysql+pymysql://freezer:freezer@localhost/freezer', }
end
it 'install the proper backend package' do
is_expected.to contain_package('python-pymysql').with(
:ensure => 'present',
:name => 'python-pymysql',
:tag => 'openstack'
)
end
end
end
shared_examples_for 'freezer::db on RedHat' do
context 'using pymysql driver' do
let :params do
{ :database_connection => 'mysql+pymysql://freezer:freezer@localhost/freezer', }
end
end
end
on_supported_os({
:supported_os => OSDefaults.get_supported_os
:supported_os => OSDefaults.get_supported_os
}).each do |os,facts|
context "on #{os}" do
let (:facts) do
facts.merge!(OSDefaults.get_facts())
end
it_configures 'freezer::db'
it_configures "freezer::db on #{facts[:osfamily]}"
it_behaves_like 'freezer::db'
end
end
end