Currently, if a users gives invalid input type for available_themses,
the logic ignores the input and reflect nothing in the config file,
which can cause unexpected results. This ensures the given input is
a hash value.
This also adds validations to ensure only required values are included
by the hash.
Change-Id: I61aefe65e6218a79dce7a0633cb0ceb13b0021b4
This fixes the missing notifications so that the httpd service is
properly restarted after config files are updated.
This also realigns package resources for separate dasobhards to
the global install phase because these packages should be installed
before config phase.
Related-Bug: #2048037
Change-Id: I8331c6c528391401c57b450be6bf75829179a9f8
The COMPRESS_ENABLED option controls whether the compression should be
enabled. This adds support for this option.
Change-Id: Ie3e48afc50770b121daacb90d8c70cf241efd330
In Debian, some files are installed into local_settings.d by their
packages and these conflict with the options added to local_settings.
This introduces an option to purge the directory.
Change-Id: I7e074f78b15ab22d86d6a6a10f573cfc4052023a
The horizon package in Debian installs the wsgi.py file at a path
different from the other distros.
Closes-Bug: #2043371
Change-Id: Idb8550dd534cd2a1bb442cd2e2256f1a8fc8d89e
The package name of ironic-ui in Ubnutu/Debian does not follow
the general naming rule and the existing horizon::dashboard can't be
used.
Closes-Bug: #2033929
Change-Id: I7703550897c6b31f2b45ffce75f0ab2bae7a4157
Horizon recently introduced TOTP support. This introduces a few new
parameters to allow users to enable the feature.
Depends-on: https://review.opendev.org/c/openstack/horizon/+/885570
Change-Id: I0b8d86c292715ffbb6d75dadcda7b51b1c190641
Recent update in rspec-puppet removed some of the config interfaces for
old puppet versions[1]. This drops usage of these interfaces to resolve
the following error in unit tests.
```
An error occurred while loading ./spec/unit/provider/manila_spec.rb.
Failure/Error: c.manifest_dir = File.join(fixture_path, 'manifests')
NoMethodError:
undefined method `manifest_dir='...
```
[1] 316d95923c
Change-Id: Ic74097dd92e23c6575284cbe61a605deac4f646c
The SESSION_TIMEOUT parameter in horizon defaults to 3600. This updates
the default in our module to use the consistent default.
Change-Id: Icb609fad8ce95f867fe467064995e665e42f253c
Since [1] was merged, all the URL options are set according to
the WEBROOT option. Also the trailing slash is added automatically.
[1] 2a772d64800070689478a49b6aa26a5893b2067b
Change-Id: Ic13cd2e541f21d07ed1b2b1337eeae042dbe2daa
Currently when any of the expected lines do not appear in the concat
fragment, the verify fails but shows only the truncated contents. This
makes it difficult to find out which line is wrong.
This split the evaluation to every single line so that more specific
error is shown.
Change-Id: I1f6233bd1fa7ec3557e622942397fe58e583e4c9
Currently we completely replace some dict values in local_settings but
this causes a few problems.
- Some keys(eg OPENSTACK_HYPERVISOR_FEATURES['enable_quotas']) are
missing from the default dict value, which overrides its default
value (True) in Horizon
- We have to maintain the default values defined in our manifest
according to any update in Horizon side.
This updates the logic to override keys only when requested, so that
the configuration basically leverage the defaults defined in Horizon.
Change-Id: I0fa105e595ff053d389e75004638af5856dbb734
The default value of can_set_mount_point
that we merge into the hypervisor_options
parameter is not the Horizon default.
This removes the defaults that sets the
can_set_mount_point to true by default when
Horizon has this as false by default, it's
also only really functional on a very specific
hypervisor.
This also removes the can_set_password config
that we set to False that already is the Horizon
default.
Change-Id: Iba05bce817da1c1bc51acb06b6bdc69beba2ea26
Signed-off-by: Tobias Urdin <tobias.urdin@binero.com>
Horizon supports loading secret key from a separate file. This change
updates the configurations to use that feature instead of putting
the key content in local_settings.
This allows us to more strictly limit access to the key content.
Change-Id: Ie91c2286afc102145ee49f5ef91b250e92af16a7
This removes the hard-coded default values for the following options
so that we can leverage the defaults defined in Horizon itself.
- API_RESULT_LIMIT
- API_RESULT_PAGE_SIZE
- DROPDOWN_MAX_ITEMS
Change-Id: Id392b959ff05bba0dd75343313b2c3f956d29565
The images_panel key in HORIZON_CONFIG setting dict was once added
during Newton cycle but was removed when ANGULAR_FEATURES option was
added in the same cycle[1].
Because the parameter has have no effect for long, this deprecates
the parameter so that we can remove it in a future release instead of
fixing it.
[1] https://review.opendev.org/c/openstack/horizon/+/353377
Change-Id: I376af3b7c4525036bf1bb449cb71490495395f2c
The pymemcache library should be installed when pymemcache backend is
used but this library is not installed by the package dependencies and
should be installed additionally.
This also ensures the cache libraries are installed during package
installation phase, so that the libraries are available when horizon
is started.
Closes-Bug: #1988205
Change-Id: I90cd9d9e1276fae71fcb9cbc7ba95b8839690dbd
This change ensures the parameters used in if-statement take boolean
values, because usage of a different type(eg. String) can cause
unexpected evaluation result.
[vagrant@localhost ~]$ cat foo.pp
$foo = false
$bar = 'False'
$baz = 'false'
if $foo { warning('foo') }
if $bar { warning('bar') }
if $baz { warning('baz') }
[vagrant@localhost ~]$ puppet apply foo.pp
Warning: Scope(Class[main]): bar
Warning: Scope(Class[main]): baz
Notice: Compiled catalog for localhost.localdomain in environment production in 0.02 seconds
Notice: Applied catalog in 0.01 seconds
[vagrant@localhost ~]$
Change-Id: I5c327c37e700829ffb80b9f58d15607aa883bdc1
This is follow-up of 625275af36 and
removes the temporal logic to keep compatibility, because we have kept
the warning message for several cycles.
Related-Bug: #1946277
Change-Id: I1b11305df67dbe3127642a96bda429faae0059d5
This is follow-up of 3ae8f91ca4 and fixes
type validation error of apache::vhost::access_log_format, which no
longer accepts a boolean value.
Related-Bug: #1983300
Change-Id: Ic5bcbcd94bfe74b0ff7ea750780021daa772a196
default_dashboard was deprecated a long ago in Horizon[1] and
Having that parameter in local_settings triggers the following warning
message.
```
WARNING:root:"dashboards" and "default_dashboard" in (local_)settings
is DEPRECATED now and may be unsupported in some future release.
The preferred way to specify the order of dashboards and the default
dashboard is the pluggable dashboard mechanism (in ...).
```
This change removes that parameter hard-coded in the template file to
get rid of the warning message. Currently the project dashboard is
shown first in Horizon by default so removing the parameter does not
cause any change in behavior.
This also removes these deprecated parameters from the template file
used in unit tests.
[1] 75bc2e6aa86d31f60288021694699302b3873af3
Closes-Bug: #1983390
Change-Id: I8cd5346a553db9ba9f6bdf8ffdd9e7d89d16c4be
Zuul