Fix puppet-lint before upgrading gem
Removing puppet-lint warnings in favor of upgrading to latest gem 2016-09-13 21:09:38.667187 | manifests/agent.pp:124:WARNING: optional parameter listed before required parameter 2016-09-13 21:09:38.667274 | manifests/agent.pp:125:WARNING: optional parameter listed before required parameter 2016-09-13 21:09:38.667302 | manifests/agent.pp:126:WARNING: optional parameter listed before required parameter 2016-09-13 21:09:38.667328 | manifests/agent.pp:127:WARNING: optional parameter listed before required parameter 2016-09-13 21:09:38.667350 | manifests/kafka/topics.pp:27:WARNING: line has more than 140 characters 2016-09-13 21:09:38.667373 | manifests/kafka/topics.pp:40:WARNING: line has more than 140 characters Change-Id: I0786132cf102be0d997ebeb5903d2fd1af681ba4
This commit is contained in:
parent
0338017c52
commit
0c7f731950
|
@ -4,9 +4,6 @@
|
|||
#
|
||||
# === Parameters
|
||||
#
|
||||
# [*enabled*]
|
||||
# flag to enable/disable the monasca agent
|
||||
#
|
||||
# [*url*]
|
||||
# url of the monasca api server to POST metrics to
|
||||
#
|
||||
|
@ -19,6 +16,9 @@
|
|||
# [*keystone_url*]
|
||||
# keystone endpoint for authentication
|
||||
#
|
||||
# [*enabled*]
|
||||
# flag to enable/disable the monasca agent
|
||||
#
|
||||
# [*project_name*]
|
||||
# name of keystone project to POST metrics for
|
||||
#
|
||||
|
@ -120,11 +120,11 @@
|
|||
# arguments to pass to the pip install command
|
||||
#
|
||||
class monasca::agent(
|
||||
$enabled = true,
|
||||
$url,
|
||||
$username,
|
||||
$password,
|
||||
$keystone_url,
|
||||
$enabled = true,
|
||||
$project_name = 'null',
|
||||
$project_domain_id = 'null',
|
||||
$project_domain_name = 'null',
|
||||
|
|
|
@ -24,7 +24,9 @@ define monasca::kafka::topics (
|
|||
) {
|
||||
|
||||
exec { "Ensure ${name} is created":
|
||||
command =>"kafka-topics.sh --create --zookeeper ${kafka_zookeeper_connections} --replication-factor ${kafka_replication_factor} --partitions ${partitions} --topic ${name}",
|
||||
# lint:ignore:140chars
|
||||
command => "kafka-topics.sh --create --zookeeper ${kafka_zookeeper_connections} --replication-factor ${kafka_replication_factor} --partitions ${partitions} --topic ${name}",
|
||||
# lint:endignore
|
||||
path => "/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin:${install_dir}/bin",
|
||||
cwd => $install_dir,
|
||||
user => 'root',
|
||||
|
@ -32,11 +34,13 @@ define monasca::kafka::topics (
|
|||
onlyif => "kafka-topics.sh --topic ${name} --list --zookeeper ${kafka_zookeeper_connections} | grep -q ${name}; test $? -ne 0"
|
||||
} ->
|
||||
exec { "Ensure ${name} is has ${partitions} partitions":
|
||||
command =>"kafka-topics.sh --alter --zookeeper ${kafka_zookeeper_connections} --partitions ${partitions} --topic ${name}",
|
||||
command => "kafka-topics.sh --alter --zookeeper ${kafka_zookeeper_connections} --partitions ${partitions} --topic ${name}",
|
||||
path => "/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin:${install_dir}/bin",
|
||||
cwd => $install_dir,
|
||||
user => 'root',
|
||||
group => 'root',
|
||||
# lint:ignore:140chars
|
||||
onlyif => "kafka-topics.sh --describe --zookeeper ${kafka_zookeeper_connections} --topic ${name} | grep 'PartitionCount:${partitions}'; test $? -ne 0"
|
||||
# lint:endignore
|
||||
}
|
||||
}
|
||||
|
|
Loading…
Reference in New Issue