Update the tox configuration to pull in the openstack
upper-constraints.txt when running releasenotes. This will
fix the releasenotes job that is currently failing due to
a new version of sphinx. Additionally this change includes
updates from puppet-modulesync-configs.
Change-Id: I212837f51e01591562fb57e4566a6c02e56c7003
mock is not used anywhere in the module, let's drop it.
This patch will help to hit this bug:
https://launchpad.net/bugs/1492636
Change-Id: Ide132846ecf1f1feb0a6d829002a150e1ffb6607
This change adds the rspec-puppet-facts gem to the spec helper so that
we can centralize the management of the base operating systems that we
support. rspec-puppet-facts allows us to simplify our unit tests and
provides a more complete list of Operating Systems and their associated
facts for the unit tests. With this change we can now loop over and
test CentOS, Debian, Fedora, RedHat, and Ubuntu by simply providing a
list of supported os to rspec-puppet-facts.
Additionally this change includes a central object for managing our
supported os list for rspec-puppet-facts and providing our default facts
like os_service_default. This central object should replace the usage of
@default_facts within the unit tests for each module.
Change-Id: Idd13701ae1d3c396b9a97bb17ef0e0a02032c489
In OpenStack Infra, we would like to run Puppet unit tests that
sometimes depends on other Puppet OpenStack modules.
Example: a patch in puppet-openstacklib that needs to be tested in puppet-nova.
This patch modifies the Rakefile to:
* clean spec_prep and spec_clean Rake tasks
* use openstack/puppet-openstack-integration/install_modules_unit.sh script
to clone modules.
* do not use .fixtures.yaml file to clone modules and rely on
zuul-cloner or git.
* Add openstack/ in gitignore so we never commit the
puppet-openstack-integration repository (can happen when spec_clean
did not run but you want to submit the patch anyway)
* Allow to run a custom Puppetfile if PUPPETFILE env is exported. It
will allow people to test the module with the dependencies they like,
feature we had with .fixtures.yaml.
Also add 'r10k' to Gemfile.
That way, we will be able to use zuul dependencies and run tests accross
modules like we do with functional testing.
Change-Id: I555bdeba198b1b468884ffce3702f5b06247d573
This patch is the initial modulesync run, it impact:
* gitignore: just a sync between projects
* gemfile:
- update and allow to setup facter version and gem source
- split beaker gems with a dedicated group
- switch to rspec-puppet 2.2.0
* rakefile:
- use the new syntax for lint configuration
- add a acceptance target
* acceptance:
- sync nodesets
- update tests in order to use zuul-cloner
* spec: added rspec coverage report
Change-Id: I481931358bff8f87b43a18c849e3b4feef36bd6a
When running with BEAKER_provision=no, the following happens:
In Trusty: beaker is running dpkg with '--force' option so even
if Puppet is already installed, the return code will be 0.
In CentOS: beaker is running 'rpm -ivh' the second time and since
the package is already here, the return code will be 1.
Using the new puppet install helper will abort installing puppet
if BEAKER_provision is no, so tests will continue as normal.
Change-Id: I74117c30d2eae269ac3e1e578943fefbd42b55b1
Co-Authored-By: Colleen Murphy <colleen@gazlene.net>
Msync commit to push all our managed modules to the default set of
configs. Being done for two reason: to address a helper library
loading issue that is addressed in
d4278834d5
and to make all module contents consistent.
Change-Id: I747e589369a7ce187dc11c981f5d327af0cf73f5
OpenStack Infra has jobs to run this on both Ubuntu Trusty and
OS7.
* Add minitest to Gemfile (dependency to run beaker on centos - see
http://projects.theforeman.org/issues/2650 for details)
* separate nodepool files to have trusty & centos7 support in OS
* infra
* spec: add case for repo configuration and support
RH systems.
* rabbitmq: install module from source
* apt: pin the module
* configure device_driver for LBaaS (update in Kilo)
Change-Id: If6c724243ba2e4932b1121b7b7f148d8b5a3f187
Closes-bug: #1444736
This patch aim to update our specs test in order to work with the
rspec-puppet release 2.0.0, in the mean time, we update rspec syntax
order to be prepared for rspec 3.x move.
In details:
* Upgrade and pin rspec-puppet from 1.0.1 to 2.0.0
* Use shared_examples "a Puppet::Error" for puppet::error tests *
* Convert 'should' keyword to 'is_expected.to' (prepare rspec 3.x) *
* Fix spec tests for rspec-puppet 2.0.0
* Clean Gemfile (remove over-specificication of runtime deps of
puppetlabs_spec_helper)
Change-Id: Ida94605916fe26dd4c5fb328f79c4e787d29dcf5
Signed-off-by: Gael Chamoulaud <gchamoul@redhat.com>
This changes the puppet-lint requirement to 1.1.x, so that we can use
puppet-lint plugins. Most of these plugins are for 4.x compat, but some
just catch common errors.
Change-Id: I44cb4ffbbc8ccd9f310240a4b1eb6fdfdb435831
Pin to rspec < 2.99 until rspec-puppet officially supports rspec 3.x.
This is to avoid warnings due to deprecated matchers in the
rspec-puppet gem.
This change is also intended to normalize the Gemfile for all stackforge
puppet modules. This should facilitate pinning gem versions when
releasing new stable branches, since the same diff can be used for all
repos.
Change-Id: Id8595fc2fd8b4e4bec4ba60d85696983fb632a18
Partial-Bug: #1326034
Pin to rspec < 2.99 until rspec-puppet officially supports rspec 3.x.
This is to avoid warnings due to deprecated matchers in the
rspec-puppet gem.
This patch also reverts the change of be_false to be_falsey that was
temporarily required for rspec 3 compability.
Partial-Bug: #1326034
Change-Id: I1f7a754cf285c598169059e757c1a905762e2ce0
Recent versions of Neutron are able to provide active notifications to
Nova about changes to port status and data. This change adds the
neutron::server::notifications class to allow Puppet to configure this
feature when setting up a Neutron server.
neutron.conf requires a tenant UUID for communicating with Nova. This
changes adds adds a custom type and provider to translate an admin
tenant name to the required UUID.
Co-Authored-By: emilienm <emilien.macchi@enovance.com>
Change-Id: I57af7cb47a12adabed9b1ee65e1c352b3e5fc2de
Closes-bug: 1306694
The latest Rake update requires Ruby >= 1.9. Bundler in the
current gate uses 1.8.x. This update fixes the gate by pinning
Rake to the last known working version.
Change-Id: I40fe97eefedbb58ad5e192193511cb94a09fc19c
Fix deprecation warnings thrown by bundler:
The source :rubygems is deprecated because HTTP requests are insecure.
Please change your source to 'https://rubygems.org' if possible,
or 'http://rubygems.org' if not.
Fixes: bug #1175767
Change-Id: I75e2f79fecac49e7e0d9a94e604368489214b7c9
Preserve rabbit_host parameter for backward compatibility.
rabbit_hosts allows the configuration of quantum with rabbit HA support.
Add rspec tests and fix various typos/bugs.
Tobias Urdin