openstack
/
puppet-nova
Code Issues Proposed changes

Secure metadata proxy shared secret 

Needs to be set to secret => true

Change-Id: I805d917f20b8dc08c1868d9c5d3b4a496c66c03f
Closes-Bug: #1676708
This commit is contained in:
Juan Antonio Osorio Robles 2017-03-28 11:27:59 +03:00
parent 210a3161e5
commit f818ccd1c4
2 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
manifests/api.pp
View File

@ -443,7 +443,7 @@ as a standalone service, or httpd for being run by a httpd server")
nova_config {
'neutron/service_metadata_proxy': value => true;
'neutron/metadata_proxy_shared_secret':
value => $neutron_metadata_proxy_shared_secret;
value => $neutron_metadata_proxy_shared_secret, secret => true;
}
} else {
nova_config {

2
spec/classes/nova_api_spec.rb
View File

@ -152,7 +152,7 @@ describe 'nova::api' do
is_expected.to contain_nova_config('api/compute_link_prefix').with('value' => 'https://10.0.0.1:7777/')
is_expected.to contain_nova_config('api/glance_link_prefix').with('value' => 'https://10.0.0.1:6666/')
is_expected.to contain_nova_config('neutron/service_metadata_proxy').with('value' => true)
is_expected.to contain_nova_config('neutron/metadata_proxy_shared_secret').with('value' => 'secrete')
is_expected.to contain_nova_config('neutron/metadata_proxy_shared_secret').with('value' => 'secrete').with_secret(true)
is_expected.to contain_nova_config('oslo_middleware/enable_proxy_headers_parsing').with('value' => true)
is_expected.to contain_nova_config('api/hide_server_address_states').with('value' => 'building')
is_expected.to contain_nova_config('api/allow_instance_snapshots').with('value' => true)