openstack
/
puppet-pacemaker
Code Issues Proposed changes

order pcmk_remote after Exec['wait-for-settle'] 

We currently have the following ordering constraints collectors:
  Exec<| title == 'wait-for-settle' |> -> Pcmk_constraint<||>
  Exec<| title == 'wait-for-settle' |> -> Pcmk_resource<||>
  Exec<| title == 'wait-for-settle' |> -> Pcmk_property<||>
  Exec<| title == 'wait-for-settle' |> -> Pcmk_bundle<||>

The problem here is that on rhel8 remotes are a dedicated puppet resource
'pcmk_remote'. From manifests/resource/remote.pp:
  if $::pacemaker::params::pcs_010 {
    pcmk_remote { $name:
      ensure => $ensure,
...
  } else {
    pcmk_resource { $name:
      ensure => $ensure,

This means that on rhel8 we do not have the guarantee that remotes will be
created after the cluster has settled. This has been observed in a real-life
scenario (the wait-for-settle took place *after* the error):

Mar 12 01:51:05 controller-0.redhat.local puppet-user[27085]: Error: /Stage[main]/Tripleo::Profile::Base::Pacemaker/Pacemaker::Resource::Remote[compute-0]/Pcmk_remote[compute-0]: Could not evaluate: backup_cib: Running: pcs cluster cib /var/lib/pacemaker/cib/puppet-cib-backup20200312-27084-1ewlz0x failed with code: 1 -> Error: unable to get cib

With this change we did not observe the above error any longer.

Co-Authored-By: Luca Miccini <lmiccini@redhat.com>
Closes-Bug: #1867105

Change-Id: Id46d22d9a0e4d092c45aed1e90d20669c6808d64
This commit is contained in:
Michele Baldessari 2020-03-12 08:55:09 +01:00
parent dcc14c8537
commit e1f66f226a
1 changed files with 1 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
manifests/corosync.pp
View File

@ -390,4 +390,5 @@ class pacemaker::corosync(
Exec<| title == 'wait-for-settle' |> -> Pcmk_resource<||>
Exec<| title == 'wait-for-settle' |> -> Pcmk_property<||>
Exec<| title == 'wait-for-settle' |> -> Pcmk_bundle<||>
Exec<| title == 'wait-for-settle' |> -> Pcmk_remote<||>
}