openstack
/
puppet-tripleo
Code Issues Proposed changes

nova/libvirt: switch vnc server binding 

On compute nodes, instead of binding vnc server on 0.0.0.0, use the IP
address provided by libvirt's t-h-t profile (hiera).

Co-Authored-By: Juan Antonio Osorio Robles <jaosorior@redhat.com>
Depends-On: Ie377c09734e9f6170daa519aed69c53fc67c366b
Closes-Bug: #1660099
(cherry picked from commit 6556123395)
Change-Id: If6b116b238a52144aad5e76c9edc7df6aa15313c
This commit is contained in:
Emilien Macchi 2017-01-31 13:20:51 -05:00
parent 915f271134
commit 1639496b0c
1 changed files with 1 additions and 12 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

13
manifests/profile/base/nova/compute/libvirt.pp
View File

@ -40,24 +40,13 @@ class tripleo::profile::base::nova::compute::libvirt (
}
}
# TODO(emilien): Some work needs to be done in puppet-nova to separate nova-compute config
# when running libvirt and libvirt itself, so we allow micro-services deployments.
if str2bool(hiera('nova::use_ipv6', false)) {
$vncserver_listen = '::0'
} else {
$vncserver_listen = '0.0.0.0'
}
if $rbd_ephemeral_storage {
class { '::nova::compute::libvirt':
libvirt_disk_cachemodes => ['network=writeback'],
libvirt_hw_disk_discard => 'unmap',
vncserver_listen => $vncserver_listen,
}
} else {
class { '::nova::compute::libvirt' :
vncserver_listen => $vncserver_listen,
}
include ::nova::compute::libvirt
}
}