openstack
/
puppet-tripleo
Code Issues Proposed changes

Throw warnings for norpm actions 

If the norpm provider attempts to do any install/update/remove actions,
we should throw a warning in the logs so people are aware that the
action did not actually take place.

Change-Id: Ieee5cac3412c709ba6b39316e455d7708cc9d22e
Closes-Bug: #1669666
(cherry picked from commit 2be36167fd)
This commit is contained in:
Alex Schultz 2017-03-03 09:21:59 -07:00
parent 6d204f4f59
commit 8a5301685b
1 changed files with 5 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
lib/puppet/provider/package/norpm.rb
View File

@ -12,6 +12,7 @@
# WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the
# License for the specific language governing permissions and limitations
# under the License.
require 'puppet'
require 'puppet/provider/package'
Puppet::Type.type(:package).provide :norpm, :source => :rpm, :parent => :rpm do
@ -24,18 +25,22 @@ Puppet::Type.type(:package).provide :norpm, :source => :rpm, :parent => :rpm do
end
def install
Puppet.warning("[norpm] Attempting to install #{name} but it will not be installed")
true
end
def uninstall
Puppet.warning("[norpm] Attempting to uninstall #{name} but it will not be removed")
true
end
def update
Puppet.warning("[norpm] Attempting to update #{name} but it will not be updated")
true
end
def purge
Puppet.warning("[norpm] Attempting to purge #{name} but it will not be removed")
true
end