Fix lint issues (doc, metadata, manifests)

Add puppet parameters lint (with puppet-lint-param-docs gem) and fix
missing documentations, this commit also fix manifest lint issues
(due to puppet-lint upgrade) and metadata.json file (SPDX license,
and open dependencies).

Change-Id: I52d00d76c42a51bcc632c856754fa930ba18bcc1

Gemfile

@@ -2,10 +2,10 @@ source 'https://rubygems.org'
 
 group :development, :test do
   gem 'puppetlabs_spec_helper', :require => false
-  gem 'puppet-lint', '~> 0.3.2'
+  gem 'metadata-json-lint'
+  gem 'puppet-lint-param-docs'
+
   gem 'rspec-puppet', '~> 1.0.1'
-  gem 'rake', '10.1.1'
-  gem 'rspec', '< 2.99'
   gem 'json'
   gem 'webmock'
 end

manifests/db/postgresql.pp

@@ -29,8 +29,8 @@ class tuskar::db::postgresql(
 
 
   postgresql::db { $dbname:
-    user      => $user,
-    password  => $password,
+    user     => $user,
+    password => $password,
   }
 
 }

metadata.json

@@ -3,7 +3,7 @@
   "version": "5.0.0",
   "author": "eNovance and StackForge Contributors",
   "summary": "Puppet module for OpenStack Tuskar",
-  "license": "Apache License 2.0",
+  "license": "Apache-2.0",
   "source": "git://github.com/stackforge/puppet-tuskar.git",
   "project_page": "https://launchpad.net/puppet-tuskar",
   "issues_url": "https://bugs.launchpad.net/puppet-tuskar",
@@ -34,6 +34,6 @@
     { "name": "puppetlabs/inifile", "version_requirement": ">=1.0.0 <2.0.0" },
     { "name": "stackforge/keystone", "version_requirement": ">=5.0.0 <6.0.0" },
     { "name": "puppetlabs/stdlib", "version_requirement": ">=4.0.0 <5.0.0" },
-    { "name": "stackforge/openstacklib", "version_requirement": ">=5.0.0" }
+    { "name": "stackforge/openstacklib", "version_requirement": ">=5.0.0 <6.0.0" }
   ]
 }