Commit Graph

542 Commits

Author SHA1 Message Date
OpenStack Release Bot 7c7609b318 Update master for stable/2024.1
Add file to the reno documentation build to show release notes for
stable/2024.1.

Use pbr instruction to increment the minor version number
automatically so that master versions are higher than the versions on
stable/2024.1.

Sem-Ver: feature
Change-Id: I14434ee93108c4739bbd29c3a57424fa6df33934
2024-04-18 10:51:46 +00:00
Zuul d35e531a0b Merge "Fix unsafe interpolations in exec" 2024-04-16 08:13:58 +00:00
Takashi Kajinami 1c44067cbe Prepare 2024.1 release
Change-Id: If20aee6da6335e155ac6b37824230aa4b0a9ade4
2024-04-15 22:36:40 +09:00
Takashi Kajinami 5fe702bcc2 Fix unsafe interpolations in exec
... to resolve the following warning detected by puppet-lint.

WARNING: unsafe interpolation of variable 'foo' in exec command

Note that the lint rule is currently disabled[1].

[1] 56cf30b7e26d2c1a440a83f67ec4d7041dcf5cdb

Change-Id: I5576174e964a9a181603e1f06145415c8ce27344
2024-04-14 15:40:20 +09:00
Zuul f9d07c8d75 Merge "reno: Update master for unmaintained/xena" 2024-04-12 13:07:29 +00:00
OpenStack Release Bot c6a10756ed reno: Update master for unmaintained/xena
Update the xena release notes configuration to build from
unmaintained/xena.

Change-Id: Ia9a7e94ebbd8515d8d9d1961ba51cc25a3b16550
2024-04-12 12:36:12 +00:00
OpenStack Release Bot 88400d8aaa reno: Update master for unmaintained/wallaby
Update the wallaby release notes configuration to build from
unmaintained/wallaby.

Change-Id: I0970b16ac48f76d276991546b1f430e28b96ffdc
2024-04-12 12:29:18 +00:00
OpenStack Release Bot 53deacaf3e reno: Update master for unmaintained/yoga
Update the yoga release notes configuration to build from
unmaintained/yoga.

Change-Id: I20cd31a8354b79d282a4cb547789e1d650cffeec
2024-02-21 16:53:24 +00:00
Takashi Kajinami bbe377bbcf vs_port: Remove redundant list-port check in RHEL/CentOS
In case the port is not associated with any physical interfaces,
the provider determines existence of the resource using the same
command. So the logic may be always activated.

On the other hand, in case the port is associated with a physical
interface, the ovs port should be created by network scripts by ifup
call, so it's not necessary to create the ovs port in advance.

Change-Id: Id0c636338d41ee9da1a76ad0264c31c56446ab77
2023-12-04 16:59:46 +09:00
Takashi Kajinami da3b76d025 vs_port: Use vs_bridge provider to obtain bridge information
... to avoid maintaining the same logic in multiple providers.

Change-Id: I9374b167de51ea164bb3c4e7d0a9df4d7c2048f1
2023-12-04 13:13:30 +09:00
Takashi Kajinami c9f2596789 Create the base ovs provider
The commands to query or update ovs db records are similar for
different resources (bridge, port and interface).

This creates the base implementation to avoid maintaining similar
logics for multiple resources.

Change-Id: Ibd75f464af984987c27548a08da26dea622c7e79
2023-11-28 11:06:39 +09:00
Takashi Kajinami 9ddd277e93 vs_bridge: Use hash for external_ids
... so that data type is consistent with actual data type in ovs.

Closes-Bug: #2044136
Change-Id: I7b861d21d35d1886d64e47ea3c1f0fb15fa1c3af
2023-11-26 14:52:29 +09:00
Zuul 4af35cdd47 Merge "vs_port: Fail early if the target bridge does not exist" 2023-11-22 16:48:10 +00:00
Takashi Kajinami bfd4a58aff vs_port: Fail early if the target bridge does not exist
... and return a sensible error to users, instead of raising failure
when one of the subsequent command fails because the bridge is not
present.

Change-Id: I8c764e3314b0deba44adffb570c4a768cee4e97a
2023-11-21 10:13:39 +00:00
Takashi Kajinami 543556dcd1 vs_bridge: Skip redundant update when updating external_ids
We don't have to set the id in case the id already exists and has
the expected value.

Change-Id: I2b02b43aff5e35dac2b29beff572472a8039c6f0
2023-11-21 13:12:40 +09:00
Takashi Kajinami 808e3104a2 Add unit test cases for bug 2043916
This is follow-up of 0f8e830a09 and
add the unit test cases to detect any regression.

Related-Bug: #2043916
Change-Id: I8a4b2bf1ca839f5b8c98000212c313498257460b
2023-11-21 13:12:29 +09:00
Zuul 848d760c63 Merge "vs_port: add unit tests for ovs provider" 2023-11-21 03:59:40 +00:00
Zuul fa1f292dd2 Merge "vs_bridge: add unit tests for ovs provider" 2023-11-21 03:59:39 +00:00
Zuul 61f2b4d6cb Merge "Re-ogranize unit tests directory" 2023-11-21 03:59:38 +00:00
Zuul affb12bf2d Merge "vs_port: Avoid detecting partial name" 2023-11-21 03:59:36 +00:00
Zuul 212dac0c02 Merge "vs_bridge: Ensure "exists?" returns true" 2023-11-20 18:52:28 +00:00
Zuul 539d8d511c Merge "vs_bridge: Ensure existing external ids are updated" 2023-11-20 18:52:26 +00:00
Zuul bb195a701b Merge "vs_bridge: Make some internal functions private" 2023-11-20 18:48:48 +00:00
Takashi Kajinami 59441b89cc vs_port: add unit tests for ovs provider
Change-Id: I25a031fe8dd352f3c08bad7327498865edeeaa03
2023-11-19 22:20:05 +09:00
Takashi Kajinami b15545331c vs_bridge: add unit tests for ovs provider
Change-Id: Id601e8f4b89f1306d3f71d9154b076207b210bb4
2023-11-19 20:53:28 +09:00
Takashi Kajinami 379d4e8c8c Re-ogranize unit tests directory
... to make the structure consistent with the other modules.

Change-Id: I3b32dd19eec086ad979441fb2484d6237e891d3a
2023-11-19 20:53:28 +09:00
Takashi Kajinami 5b42cda62f vs_port: Avoid detecting partial name
This ensures that a different port, which includes name of the port
being created, is ignored when checking whether the target already
exists.

Closes-Bug: #2043921
Change-Id: I4a8db4e7b0da87a00ef097c8e066a11bfc5fde90
2023-11-19 20:53:28 +09:00
Takashi Kajinami 35d4713eae vs_bridge: Ensure "exists?" returns true
... instead of nothing.

Change-Id: Ifd943f99a7b0a7d12170e773ffd02bd61a0eb2bc
2023-11-19 19:03:13 +09:00
Takashi Kajinami 0f8e830a09 vs_bridge: Ensure existing external ids are updated
... and also the ids not included by the given list are purged.

Closes-Bug: #2043916
Change-Id: I058614b9113edd6e65238b924e5f474cab37946e
2023-11-19 17:07:00 +09:00
Takashi Kajinami 141ef5b6f5 vs_bridge: Make some internal functions private
... because these are only for internal use.

Change-Id: I6ce9b29c2d43fc450816df945003a9fbb82bb6da
2023-11-19 16:38:41 +09:00
Takashi Kajinami 3aad7379ab Bump supported Debian version to 12 (Bookworm)
Debian 12 was released in June 2023. Recent versions of OpenStack
(actually, 2023.1 and later) no longer support Debian 11.

Change-Id: I5da2e3dab813de45d392208019a98f12d9ce5fed
2023-11-18 09:26:05 +00:00
Takashi Kajinami 6e019b361b Fix minimum value of handler/revalidator_cores
n-revalidator-threads and n-handler-threads does not accept 1 and
the value should be >= 1.

Change-Id: I4428b241290a238610aa46419a1e7abd2c8afbb9
2023-11-10 02:25:32 +09:00
Zuul fc34b4cd49 Merge "Replace params by hieradata" 2023-10-30 09:28:44 +00:00
Takashi Kajinami 10f574dc53 Replace params by hieradata
The params class is the legacy approach to define OS/version specific
values. This replaces the params class by the module hieradata
following the recent standard.

Change-Id: I046267279720e969b0ddde821fafff00e517e728
2023-10-17 11:05:19 +09:00
Zuul f7f20ab7f7 Merge "Update master for stable/2023.2" 2023-10-16 18:24:00 +00:00
OpenStack Release Bot 1efc359892 Update master for stable/2023.2
Add file to the reno documentation build to show release notes for
stable/2023.2.

Use pbr instruction to increment the minor version number
automatically so that master versions are higher than the versions on
stable/2023.2.

Sem-Ver: feature
Change-Id: Ia04adbc0d65d1922819c7a857e8160b1c343085b
2023-10-16 15:21:00 +00:00
Takashi Kajinami 91231c2eea dpdk: Allow Debian OS family
We've been limiting dpdk support to RHEL family but we don't have any
specific reasons to do so.

Change-Id: I0e97f00df57a7f8d35b8941c1a6a5309f25852ff
2023-10-15 02:14:34 +09:00
Takashi Kajinami ec83ceaf4e Remove usage of deleted manifest_dir
Recent update in rspec-puppet removed some of the config interfaces for
old puppet versions[1]. This drops usage of these interfaces to resolve
the following error in unit tests.

```
An error occurred while loading ./spec/unit/provider/manila_spec.rb.
Failure/Error: c.manifest_dir = File.join(fixture_path, 'manifests')

NoMethodError:
  undefined method `manifest_dir='...
```

This also removes explicit setting of mock module. The definition is
no longer required since we bumped puppetlabs_spec_helper to v 5.0.0.

[1] 316d95923c

Change-Id: Ic5f1499d207e7f26598632499dafbafe5c6d37ab
2023-10-11 12:12:03 +09:00
Zuul 5d6c0c58dd Merge "Prepare 2023.2 release" 2023-10-03 17:38:41 +00:00
Zuul f8805ed0e8 Merge "Drop unused openstacklib dependency" 2023-10-03 17:38:40 +00:00
Takashi Kajinami 2356fbe5f1 Prepare 2023.2 release
Change-Id: I8e4489ca59694b36476898b4d24b0ae1c241b3d5
2023-10-03 14:28:46 +00:00
Takashi Kajinami 0052af18aa Drop unused openstacklib dependency
This module no longer depends on openstacklib since support for
os_service_default fact was removed by [1].

[1] b70e038fe5

Change-Id: Idbaee5937d3686bdaa24b6ea7c954d876202dd8e
2023-10-03 23:28:19 +09:00
Takashi Kajinami 9df499a917 Bump upper version of stdlib
... because we are currently using v9.0.0 in CI. Lower version may be
bumped after 2023.2 release.

Change-Id: I0753e2a6e919ece2af39ce2c0acc1b3e7612b296
2023-10-03 13:30:08 +09:00
Zuul 3c73d5f942 Merge "replace validate_legacy with proper data types" 2023-09-14 12:22:50 +00:00
Takashi Kajinami 9afc8c28e5 Exclude release note files
The directory contains the source files to generate the release note
document, so is not required.

Change-Id: I50802c6ede44982c81a43e9743b4a33da1156276
2023-08-11 18:01:47 +09:00
Takashi Kajinami 1e9c90af7e Add .pdkignore to exclude some files from tar ball
We've seen release job failures caused by too large tarball, which
contains irrelevant files like git history.

Let's exclude these files to reduce size of the archive.

The file is copied from the puppetlabs repositories with some files
specific to OpenStack projects added.

Change-Id: I97ab5acab1c9c280fd4d943a59b5e0f60828876a
2023-08-11 00:54:12 +09:00
Takashi Kajinami 124238c25b replace validate_legacy with proper data types
the validate_legacy function is marked for deprecation in
v9.0.0 from puppetlabs-stdlib.

This also adds type definitions for all parameters.

Change-Id: I0e68a74bdae6e39ada7707f46e54ec180476c0dc
2023-07-13 12:50:12 +09:00
Takashi Kajinami 2ffc7aedf4 Re-organize service definitions
None of supported operating systems have separate ovsdb-service, so
the logic to enable that separate service is unused and useless.

Also current definition of status and hasstatus are just redundant and
can be removed.

Change-Id: I361e55f144b4852f76c00b8dab26c4cec37b29c1
2023-06-19 13:32:22 +09:00
Takashi Kajinami 54106dc6da Remove support for Puppet 6
... because Puppet 6 reached its EOL in February 2023.

Change-Id: If1bc84b985087975206ed2702c1676cd093cb9ed
2023-05-22 12:32:16 +09:00
OpenStack Release Bot 5dc38367e5 Update master for stable/2023.1
Add file to the reno documentation build to show release notes for
stable/2023.1.

Use pbr instruction to increment the minor version number
automatically so that master versions are higher than the versions on
stable/2023.1.

Sem-Ver: feature
Change-Id: I0584131016fba5393bcec785f651890eead5adca
2023-04-05 15:37:14 +00:00