openstack
/
python-barbicanclient
Code Issues Proposed changes

New mock release(1.1.0) broke unit/function tests 

Change-Id: Ife0ff0789e6360d405dd371902c88b6819c48d7f
Closes-Bug: #1473454
This commit is contained in:
rico.lin 2015-07-11 13:20:24 +08:00
parent 19c1acc1a4
commit 1006223a1f
2 changed files with 6 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
barbicanclient/tests/test_client.py
View File

@ -105,7 +105,7 @@ class WhenTestingClientPost(TestClient):
def test_post_checks_status_code(self):
self.httpclient._check_status_code = mock.MagicMock()
self.httpclient.post(path='secrets', json={'test_data': 'test'})
self.httpclient._check_status_code.assert_called()
self.assertTrue(self.httpclient._check_status_code.called)
class WhenTestingClientGet(TestClient):
@ -144,7 +144,7 @@ class WhenTestingClientGet(TestClient):
def test_get_checks_status_code(self):
self.httpclient._check_status_code = mock.MagicMock()
self.httpclient.get(self.href)
self.httpclient._check_status_code.assert_called()
self.assertTrue(self.httpclient._check_status_code.called)
def test_get_raw_uses_href_as_is(self):
self.httpclient._get_raw(self.href, headers=self.headers)
@ -163,7 +163,7 @@ class WhenTestingClientGet(TestClient):
def test_get_raw_checks_status_code(self):
self.httpclient._check_status_code = mock.MagicMock()
self.httpclient._get_raw(self.href, headers=self.headers)
self.httpclient._check_status_code.assert_called()
self.assertTrue(self.httpclient._check_status_code.called)
class WhenTestingClientDelete(TestClient):
@ -194,7 +194,7 @@ class WhenTestingClientDelete(TestClient):
def test_delete_checks_status_code(self):
self.httpclient._check_status_code = mock.MagicMock()
self.httpclient.delete(self.href)
self.httpclient._check_status_code.assert_called()
self.assertTrue(self.httpclient._check_status_code.called)
class WhenTestingCheckStatusCodes(TestClient):

3
test-requirements.txt
View File

@ -6,7 +6,8 @@ discover
hacking<0.11,>=0.10.0
fixtures>=1.3.1
requests-mock>=0.6.0 # Apache-2.0
mock>=1.0
mock>=1.0;python_version!='2.6'
mock==1.0.1;python_version=='2.6'
testrepository>=0.0.18
testtools>=1.4.0
oslotest>=1.5.1 # Apache-2.0