openstack
/
python-cinderclient
Code Issues Proposed changes

Remove bash-completion calls from base.py 

This should not be here since this is client
library code, but it isn't needed anyhow since
this completion is handled from the shell code.

Closes-Bug: #1817782

Change-Id: I3e7ddbe4a50a66db8961a71d71592ce708320b0d
This commit is contained in:
Eric Harney 2019-04-02 10:46:52 -04:00
parent a39805c6f4
commit 0707191d43
1 changed files with 3 additions and 9 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
cinderclient/base.py
View File

@ -91,12 +91,8 @@ class Manager(common_base.HookableMixin):
except KeyError:
pass
# FIXME(eharney): This is probably a bug - we should only call
# completion_cache for the shell, not here.
with self.completion_cache('human_id', obj_class, mode="w"):
with self.completion_cache('uuid', obj_class, mode="w"):
items_new = [obj_class(self, res, loaded=True)
for res in data if res]
items_new = [obj_class(self, res, loaded=True)
for res in data if res]
if limit:
limit = int(limit)
margin = limit - len(items)
@ -330,9 +326,7 @@ class Manager(common_base.HookableMixin):
if return_raw:
return common_base.DictWithMeta(body[response_key], resp)
with self.completion_cache('human_id', self.resource_class, mode="a"):
with self.completion_cache('uuid', self.resource_class, mode="a"):
return self.resource_class(self, body[response_key], resp=resp)
return self.resource_class(self, body[response_key], resp=resp)
def _delete(self, url):
resp, body = self.api.client.delete(url)