Replace assertTrue(isinstance()) by optimal assert
assertTrue(isinstance(A, B)) or assertEqual(type(A), B) in tests should be replaced by assertIsInstance(A, B) provided by testtools. Related-bug: #1268480 Change-Id: I755702d0f6e982d7cba173fbbdb86feb8ab384a0
This commit is contained in:
parent
7476dbd8dc
commit
c297309aff
|
@ -29,7 +29,7 @@ class TypeAccessTest(utils.TestCase):
|
|||
access = cs.volume_type_access.list(volume_type='3')
|
||||
cs.assert_called('GET', '/types/3/os-volume-type-access')
|
||||
for a in access:
|
||||
self.assertTrue(isinstance(a, volume_type_access.VolumeTypeAccess))
|
||||
self.assertIsInstance(a, volume_type_access.VolumeTypeAccess)
|
||||
|
||||
def test_add_project_access(self):
|
||||
cs.volume_type_access.add_project_access('3', PROJECT_UUID)
|
||||
|
|
Loading…
Reference in New Issue