openstack
/
python-cinderclient
Code Issues Proposed changes

base.Resource not define __ne__() built-in function 

Class base.Resource defines __eq__() built-in function, but does
not define __ne__() built-in function, so self.assertEqual works
but self.assertNotEqual does not work at all in this test case in
python2. This patch fixes it by defining __ne__() built-in function
of class base.Resource. Also fixes spelling errors:resoruces.

Change-Id: I845d531880ad74d928a3e15335ed10e71590826e
Closes-Bug: #1586268
This commit is contained in:
yuyafei 2016-05-28 16:10:15 +08:00
parent b734a1b0ed
commit ccde9b3ba7
2 changed files with 4 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
cinderclient/openstack/common/apiclient/base.py
View File

@ -524,6 +524,9 @@ class Resource(RequestIdMixin):
return False
return self._info == other._info
def __ne__(self, other):
return not self.__eq__(other)
def is_loaded(self):
return self._loaded

2
cinderclient/tests/unit/test_base.py
View File

@ -58,7 +58,7 @@ class BaseTest(utils.TestCase):
r2 = base.Resource(None, {'id': 1, 'name': 'hello'})
self.assertEqual(r1, r2)
# Two resoruces of different types: never equal
# Two resources of different types: never equal
r1 = base.Resource(None, {'id': 1})
r2 = volumes.Volume(None, {'id': 1})
self.assertNotEqual(r1, r2)