openstack
/
python-designateclient
Code Issues Proposed changes

Replace assertEqual(None, *) with assertIsNone in tests 

Replace assertEqual(None, *) with assertIsNone in tests to have
more clear messages in case of failure.

Change-Id: Ifcaeba48ff3606d3805343923378d0e58f68a2b9
Closes-bug: #1280522
This commit is contained in:
Shuquan Huang 2015-12-17 21:44:42 +08:00
parent 9f7ad0d435
commit 940b610af0
1 changed files with 4 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
designateclient/tests/v2/test_timeout.py
View File

@ -77,15 +77,15 @@ class TestTimeout(v2.APIV2TestCase, v2.CrudMixin):
def test_no_timeout(self):
session = create_session(timeout=None)
client = Client(session=session)
self.assertEqual(None, session.timeout)
self.assertEqual(None, client.session.timeout)
self.assertIsNone(session.timeout)
self.assertIsNone(client.session.timeout)
self._call_request_and_check_timeout(client, None)
def test_timeout_in_session(self):
session = create_session(timeout=1)
client = Client(session=session)
self.assertEqual(1, session.timeout)
self.assertEqual(None, client.session.timeout)
self.assertIsNone(client.session.timeout)
self._call_request_and_check_timeout(client, 1)
def test_timeout_override_session_timeout(self):
@ -100,7 +100,7 @@ class TestTimeout(v2.APIV2TestCase, v2.CrudMixin):
session = create_session(timeout=1)
client = Client(session=session)
self.assertEqual(1, session.timeout)
self.assertEqual(None, client.session.timeout)
self.assertIsNone(client.session.timeout)
self._call_request_and_check_timeout(client, 1)
session.timeout = 2