image-create-via-import fails with ValueError

CLI image-create-via-import fails with ValueError. The reason
is create command returns RequestIdWrapper object and not image
and response.

Further it fails with AttributeError: 'Namespace' object has
no attribute 'import_method'. The reason is do_import_image() call
requires 'import_method' as input which is not provided at the
moment.

Change-Id: Ic4c4d1f3c5d290b584840e8f9047fb53611a5748
Closes-bug: #1711511
This commit is contained in:
Abhishek Kekane 2017-08-18 12:52:53 +05:30
parent 40a2d25abd
commit 335f1e9447
1 changed files with 4 additions and 1 deletions

View File

@ -102,6 +102,9 @@ def do_image_create(gc, args):
'passed to the client via stdin.'))
@utils.arg('--progress', action='store_true', default=False,
help=_('Show upload progress bar.'))
@utils.arg('--import-method', metavar='<METHOD>', default='glance-direct',
help=_('Import method used for Image Import workflow. '
'Valid values can be retrieved with import-info command.'))
@utils.on_data_require_fields(DATA_FIELDS)
def do_image_create_via_import(gc, args):
"""EXPERIMENTAL: Create a new image via image import."""
@ -126,7 +129,7 @@ def do_image_create_via_import(gc, args):
'glance-direct' not in import_methods.get('value')):
utils.exit("No suitable import method available for direct upload, "
"please use image-create instead.")
image, resp = gc.images.create(**fields)
image = gc.images.create(**fields)
try:
if utils.get_data_file(args) is not None:
args.id = image['id']