openstack
/
python-heatclient
Code Issues Proposed changes

Handle log message interpolation by the logger 

According to OpenStack Guideline[1], logged string message should be
interpolated by the logger.

[1]: http://docs.openstack.org/developer/oslo.i18n/guidelines.html#adding-variables-to-log-messages

Change-Id: Icbf550eecc0108e928aeb9e39dd28dfe482abe4b
Closes-Bug: #1661262
This commit is contained in:
Gábor Antal 2017-02-07 15:48:37 +01:00
parent d7cb611e5c
commit 28d8082f9b
1 changed files with 5 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
heatclient/osc/v1/snapshot.py
View File

@ -40,7 +40,7 @@ class ListSnapshot(command.Lister):
return parser
def take_action(self, parsed_args):
self.log.debug('take_action(%s)' % parsed_args)
self.log.debug('take_action(%s)', parsed_args)
heat_client = self.app.client_manager.orchestration
return self._list_snapshot(heat_client, parsed_args)
@ -80,7 +80,7 @@ class ShowSnapshot(format_utils.YamlFormat):
return parser
def take_action(self, parsed_args):
self.log.debug('take_action(%s)' % parsed_args)
self.log.debug('take_action(%s)', parsed_args)
heat_client = self.app.client_manager.orchestration
return self._show_snapshot(heat_client, parsed_args.stack,
parsed_args.snapshot)
@ -119,7 +119,7 @@ class RestoreSnapshot(command.Command):
return parser
def take_action(self, parsed_args):
self.log.debug('take_action(%s)' % parsed_args)
self.log.debug('take_action(%s)', parsed_args)
heat_client = self.app.client_manager.orchestration
return self._restore_snapshot(heat_client, parsed_args)
@ -155,7 +155,7 @@ class CreateSnapshot(command.ShowOne):
return parser
def take_action(self, parsed_args):
self.log.debug('take_action(%s)' % parsed_args)
self.log.debug('take_action(%s)', parsed_args)
heat_client = self.app.client_manager.orchestration
try:
@ -195,7 +195,7 @@ class DeleteSnapshot(command.Command):
return parser
def take_action(self, parsed_args):
self.log.debug('take_action(%s)' % parsed_args)
self.log.debug('take_action(%s)', parsed_args)
heat_client = self.app.client_manager.orchestration
try:
heat_client.stacks.snapshot_delete(parsed_args.stack,