openstack
/
python-ironicclient
Code Issues Proposed changes

Replace assertTrue with explicit assertIsInstance 

Replace assertTrue(isinstance()) with assertIsInstance().

Change-Id: Ie2dabe3a8da23eba7ff1026311dd44465a7587ab
Closes-Bug: #1268480
This commit is contained in:
Kan 2016-01-05 02:42:52 +00:00
parent ced49ed5e3
commit 0495d3d462
1 changed files with 3 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
ironicclient/tests/unit/apiclient/test_exceptions.py
View File

@ -41,7 +41,7 @@ class ExceptionsArgsTest(test_base.BaseTestCase):
json_data=json_data),
method,
url)
self.assertTrue(isinstance(ex, ex_cls))
self.assertIsInstance(ex, ex_cls)
if check_description:
expected_msg = error_msg or json_data["error"]["message"]
expected_details = error_details or json_data["error"]["details"]
@ -114,7 +114,7 @@ class ExceptionsArgsTest(test_base.BaseTestCase):
text=text_data1),
method,
url)
self.assertTrue(isinstance(ex, exceptions.BadRequest))
self.assertIsInstance(ex, exceptions.BadRequest)
self.assertEqual(ex.details, text_data1)
self.assertEqual(ex.method, method)
self.assertEqual(ex.url, url)
@ -130,7 +130,7 @@ class ExceptionsArgsTest(test_base.BaseTestCase):
headers={"Content-Type": "text/html"}),
method,
url)
self.assertTrue(isinstance(ex, exceptions.Unauthorized))
self.assertIsInstance(ex, exceptions.Unauthorized)
self.assertEqual(ex.details, '')
self.assertEqual(ex.method, method)
self.assertEqual(ex.url, url)