Replace assertEqual(None, *) with assertIsNone in tests

Replace assertEqual(None, *) with assertIsNone in tests to have
more clear messages in case of failure.

Change-Id: I109bef1afbbdd3a2cf25e9fb7133509516910891
Closes-bug: #1280522
This commit is contained in:
Shuquan Huang 2015-12-17 20:54:09 +08:00
parent 5751b32932
commit a90b16ca84
1 changed files with 5 additions and 5 deletions

View File

@ -735,7 +735,7 @@ class NodeManagerTest(testtools.TestCase):
('PUT', '/v1/nodes/%s/maintenance' % NODE1['uuid'], {}, body),
]
self.assertEqual(expect, self.api.calls)
self.assertEqual(None, maintenance)
self.assertIsNone(maintenance)
def test_node_set_maintenance_false(self):
maintenance = self.mgr.set_maintenance(NODE1['uuid'], 'false')
@ -743,7 +743,7 @@ class NodeManagerTest(testtools.TestCase):
('DELETE', '/v1/nodes/%s/maintenance' % NODE1['uuid'], {}, None),
]
self.assertEqual(expect, self.api.calls)
self.assertEqual(None, maintenance)
self.assertIsNone(maintenance)
def test_node_set_maintenance_on(self):
maintenance = self.mgr.set_maintenance(NODE1['uuid'], 'on',
@ -753,7 +753,7 @@ class NodeManagerTest(testtools.TestCase):
('PUT', '/v1/nodes/%s/maintenance' % NODE1['uuid'], {}, body),
]
self.assertEqual(expect, self.api.calls)
self.assertEqual(None, maintenance)
self.assertIsNone(maintenance)
def test_node_set_maintenance_off(self):
maintenance = self.mgr.set_maintenance(NODE1['uuid'], 'off')
@ -761,7 +761,7 @@ class NodeManagerTest(testtools.TestCase):
('DELETE', '/v1/nodes/%s/maintenance' % NODE1['uuid'], {}, None),
]
self.assertEqual(expect, self.api.calls)
self.assertEqual(None, maintenance)
self.assertIsNone(maintenance)
def test_node_set_maintenance_bad(self):
self.assertRaises(exc.InvalidAttribute, self.mgr.set_maintenance,
@ -775,7 +775,7 @@ class NodeManagerTest(testtools.TestCase):
('PUT', '/v1/nodes/%s/maintenance' % NODE1['uuid'], {}, body),
]
self.assertEqual(expect, self.api.calls)
self.assertEqual(None, maintenance)
self.assertIsNone(maintenance)
def test_node_set_power_state(self):
power_state = self.mgr.set_power_state(NODE1['uuid'], "on")