Module novaclient.v1_1 is used as implementation of V1.1, V2 and V3.
Since future development(microversioning) will be done across V2,
implementation should be done in appropriate module(to prevent misleading).
Despite the fact that implementation for all versions are equal, discover
method for contrib path worked only for v1.1. This patch fixes this bug and
modifies shell tests to check all versions.
Change-Id: Ib6798f4dfe177586302141f522dc593560ce6a5b
Module gettextutils from oslo-incubator was graduated to separate
library (oslo.i18n) and removed from repository, so we should use
new library.
Change-Id: I15d36ac5a2bb88b332ffa38d29488b75c55a20a9
This change make all the text visible by the user i18n. The
messages changes are in prints, logs, exceptions, helps, etc
Pep8 errors about "Multiple positional placeholders" also fixed
Change-Id: I731afea790baddbc34d059b93a35e3d275fc1df8
The Changes include:
- Sanity check for from_port, to_port, and IP protocol when adding
a security rule
- Print one more column 'Id' for security groups
- If there are multiple security groups with the same name, the group
can't be deleted unless an ID is specified. However, there is no code
to search and delete security group by ID. So, _get_secgroup() will
get group by ID if the input is like a UUID. If not found, then get
group by name.
- Some corresponding changes for help messages.
- Test case changes after adding sanity check.
Change-Id: Ibd82d8404bdd64e4bca2f8b25756bfaff7b28194
Signed-off-by: Shane Wang <shane.wang@intel.com>
ManagerWithFind requires list() method in its descendants.
Make it abstract and fix its improper descendants that do
not implement list() (SecurityGroupRuleManager and many others).
Fixes: bug #1180393
Change-Id: Ic8b466a57554018092c31c6d6b3ea62f181d7000
Some methods which should have returned objects dit not return and some
methods which don't return anything used return ... Fixed all that and
added tests to detect two returns which were missing.
Fixes bug 892058
Change-Id: If59468cfe1c7b1ab74ed0bfc6f81590dfd5dd668
Andrey Kurilin