openstack
/
python-novaclient
Code Issues Proposed changes
OpenStack Compute (Nova) Client
3,142 Commits 9 Branches 33 Tags 35 MiB
Python 100%
Go to file
Andrey Kurilin 6049be67c0 [CLI] Fix token auth type 
There are 2 known issues which breaks token auth method in CLI:

* The wrong check of flag (the check should be for --os-token since
  arguments are not parsed at that moment) is performed in CLI inner method
  `_append_global_identity_args`. It led to usage of "password" auth
  type by default[1] even if `--os-token` cli argument is specified.
  If `--os-auth-type` is specified to token, keystoneauth1 library makes
  the right decision[2].

* Based on an auth type, keystoneauth library registers different CLI
  arguments[3]. It means that `--os-username` argument is available only
  in password auth type, `--os-token` is available only in token auth
  type, etc.
  It also affects the way in which the python code should access such
  arguments. The arguments which are unrelated to the selected auth type
  are omitted from the parsed arguments object.
  That sounds reasonable, but unfortunately the code assumes the
  unrelated arguments are always present which leads to an
  AttributeError.

Combination of these 2 issues made token auth type broken in CLI layer.

[1] ee2221f052/novaclient/shell.py (L255-L257)
[2] 14dd37b34c/keystoneauth1/loading/cli.py (L51-L52)
[3] 14dd37b34c/keystoneauth1/loading/cli.py (L65-L73)

Closes-Bug: #1659015
Change-Id: Ibc861d396b71fe105288d8336623cc22cf92523e
 		2018-04-19 18:43:45 +00:00
doc Replace GB with GiB 2018-04-04 00:08:52 +00:00
novaclient [CLI] Fix token auth type 2018-04-19 18:43:45 +00:00
playbooks/legacy/novaclient-dsvm-functional Optimize jobs run on novaclient 2017-12-13 03:43:32 +03:00
releasenotes Microversion 2.61 - support extra_specs in flavor API 2018-04-17 10:02:35 -04:00
tools Avoid tox_install.sh for constraints support 2017-12-02 16:52:17 +00:00
.coveragerc Change ignore-errors to ignore_errors 2015-09-21 14:54:09 +00:00
.gitignore doc: Create directory structure for docs migration 2017-07-12 15:07:35 +01:00
.gitreview Add .gitreview config file for gerrit. 2011-11-16 09:23:10 -08:00
.mailmap Add mailmap entry 2014-05-07 12:16:41 -07:00
.testr.conf Set test timout to 300 seconds 2017-03-23 14:55:17 -04:00
.zuul.yaml add lower-constraints job 2018-03-22 17:57:39 -04:00
CONTRIBUTING.rst Update URLs in docs, comments and setup.cfg 2017-07-28 12:14:12 +09:00
HACKING.rst Update URLs in docs, comments and setup.cfg 2017-07-28 12:14:12 +09:00
LICENSE whitespace cleanups 2011-08-08 13:25:29 -07:00
README.rst Update URLs in docs, comments and setup.cfg 2017-07-28 12:14:12 +09:00
babel.cfg Enable i18n with Babel. 2015-09-08 10:10:25 -07:00
bindep.txt Update URLs in docs, comments and setup.cfg 2017-07-28 12:14:12 +09:00
lower-constraints.txt add lower-constraints job 2018-03-22 17:57:39 -04:00
requirements.txt Updated from global requirements 2018-02-17 10:16:08 +00:00
setup.cfg Merge "Remove custom autodoc implementation" 2017-08-01 16:33:41 +00:00
setup.py Updated from global requirements 2017-03-06 01:18:45 +00:00
test-requirements.txt Updated from global requirements 2018-03-23 01:50:05 +00:00
tox.ini add lower-constraints job 2018-03-22 17:57:39 -04:00

README.rst

Team and repository tags

image

Python bindings to the OpenStack Compute API

Latest Version

Downloads

This is a client for the OpenStack Compute API. It provides a Python API (the novaclient module) and a command-line script (nova). Each implements 100% of the OpenStack Compute API.