openstack
/
python-openstackclient
Code Issues Proposed changes

Search by user defined ID for service providers 

IDs for service providers can be user defined (like, Bob). This
causes issues with the usual get by ID method.

Keystone server side has implemented changes to search by ID when
listing, which should resolve the issue with minimal changes to
the client side.

Change-Id: Ic705806e4bc7bb24f946a1fce803a0a0a4d788c1
Closes-Bug: 1555830
This commit is contained in:
Steve Martinelli 2016-03-11 04:06:18 -05:00 committed by Steve Martinelli
parent 17bc850440
commit 58094bff80
2 changed files with 3 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
openstackclient/identity/v3/service_provider.py
View File

@ -192,7 +192,8 @@ class ShowServiceProvider(command.ShowOne):
service_client = self.app.client_manager.identity
service_provider = utils.find_resource(
service_client.federation.service_providers,
parsed_args.service_provider)
parsed_args.service_provider,
id=parsed_args.service_provider)
service_provider._info.pop('links', None)
return zip(*sorted(six.iteritems(service_provider._info)))

1
openstackclient/tests/identity/v3/test_service_provider.py
View File

@ -408,6 +408,7 @@ class TestServiceProviderShow(TestServiceProvider):
self.service_providers_mock.get.assert_called_with(
service_fakes.sp_id,
id='BETA'
)
collist = ('auth_url', 'description', 'enabled', 'id', 'sp_url')