openstack
/
python-openstackclient
Code Issues Proposed changes

Fix quota-update issue in LBaaS 

Currently L7Policies cannot be updated( it was missing
in implementation in neutronclient). The same has been
taken care in the current patch.

Also, currently quota doesnt support updating the members
in an LBaaS pool. This patch temporarily removes it, till
it is not confirmed that LBaaS v2 needs to support quotas
for members or not.

Change-Id: I25a54a57debb762a32a280ece8c081fc52365f0f
Closes-Bug: #1624097
This commit is contained in:
Reedip 2016-09-16 13:39:54 +05:30
parent d3e9361796
commit 91c4509afe
3 changed files with 5 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
openstackclient/common/quota.py
View File

@ -74,8 +74,8 @@ NETWORK_QUOTAS = {
'rbac_policy': 'rbac-policies',
'vip': 'vips',
'subnetpool': 'subnetpools',
'member': 'members',
'healthmonitor': 'health-monitors',
'l7policy': 'l7policies',
}

6
openstackclient/tests/unit/common/test_quota.py
View File

@ -249,8 +249,8 @@ class TestQuotaSet(TestQuota):
'--rbac-policies', str(network_fakes.QUOTA['rbac_policy']),
'--ports', str(network_fakes.QUOTA['port']),
'--vips', str(network_fakes.QUOTA['vip']),
'--members', str(network_fakes.QUOTA['member']),
'--health-monitors', str(network_fakes.QUOTA['healthmonitor']),
'--l7policies', str(network_fakes.QUOTA['l7policy']),
identity_fakes.project_name,
]
verifylist = [
@ -265,8 +265,8 @@ class TestQuotaSet(TestQuota):
('rbac_policy', network_fakes.QUOTA['rbac_policy']),
('port', network_fakes.QUOTA['port']),
('vip', network_fakes.QUOTA['vip']),
('member', network_fakes.QUOTA['member']),
('healthmonitor', network_fakes.QUOTA['healthmonitor']),
('l7policy', network_fakes.QUOTA['l7policy']),
]
parsed_args = self.check_parser(self.cmd, arglist, verifylist)
@ -283,8 +283,8 @@ class TestQuotaSet(TestQuota):
'rbac_policy': network_fakes.QUOTA['rbac_policy'],
'port': network_fakes.QUOTA['port'],
'vip': network_fakes.QUOTA['vip'],
'member': network_fakes.QUOTA['member'],
'healthmonitor': network_fakes.QUOTA['healthmonitor'],
'l7policy': network_fakes.QUOTA['l7policy'],
}
self.network_mock.update_quota.assert_called_once_with(
identity_fakes.project_id,

1
openstackclient/tests/unit/network/v2/fakes.py
View File

@ -34,6 +34,7 @@ QUOTA = {
"vip": 10,
"member": 10,
"healthmonitor": 10,
"l7policy": 5,
}