Replace 'MagicMock' with 'Mock'
MagicMock magically allow things to pass. Any usage should be replaced with the Mock class and explicit attributes should be set on it. [1] [1] http://stackoverflow.com/questions/17181687/mock-vs-magicmock Change-Id: I8a312d8a17dcf1b09ca507aad97bba7bbb2d8a2b
This commit is contained in:
parent
c3cf67f5e5
commit
bdf3095b5d
|
@ -21,7 +21,7 @@ class FacetsManagerTest(testtools.TestCase):
|
|||
def setUp(self):
|
||||
super(FacetsManagerTest, self).setUp()
|
||||
self.manager = facets.FacetsManager(None)
|
||||
self.manager.client = mock.MagicMock()
|
||||
self.manager.client = mock.Mock()
|
||||
|
||||
def test_list_all_projects(self):
|
||||
self.manager.list(all_projects=True)
|
||||
|
|
|
@ -20,6 +20,6 @@ class ResourceTypeManagerTest(testtools.TestCase):
|
|||
|
||||
def test_list(self):
|
||||
manager = resource_types.ResourceTypeManager(None)
|
||||
manager._list = mock.MagicMock()
|
||||
manager._list = mock.Mock()
|
||||
manager.list()
|
||||
manager._list.assert_called_once_with('/v1/search/plugins', 'plugins')
|
||||
|
|
|
@ -21,7 +21,7 @@ class SearchManagerTest(testtools.TestCase):
|
|||
def setUp(self):
|
||||
super(SearchManagerTest, self).setUp()
|
||||
self.manager = search.SearchManager(None)
|
||||
self.manager._post = mock.MagicMock()
|
||||
self.manager._post = mock.Mock()
|
||||
|
||||
def test_search_with_query(self):
|
||||
query_string = {
|
||||
|
|
Loading…
Reference in New Issue