openstack
/
python-tripleoclient
Code Issues Proposed changes

Always use absolute path for tht_root 

If you don't use the absolute path then the logic in
_process_and_upload_environment breaks and deployment fails

We probably need a more comprehensive fix but this provides a
stopgap solution while we figure out how to rework this.

Change-Id: I9c6a7394d1f831ab7f0b774f675f77f924fea335
Partial-Bug: #1623552
This commit is contained in:
Steven Hardy 2016-09-20 12:39:43 +01:00
parent 698655303e
commit 0ab4114b1b
2 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
tripleoclient/tests/v1/overcloud_deploy/test_overcloud_deploy.py
View File

@ -401,7 +401,7 @@ class TestDeployOvercloud(fakes.TestDeployOvercloud):
mock_validate_args.assert_called_once_with(parsed_args)
mock_tarball.create_tarball.assert_called_with(
'/usr/share/openstack-tripleo-heat-templates/', mock.ANY)
'/usr/share/openstack-tripleo-heat-templates', mock.ANY)
mock_tarball.tarball_extract_to_swift_container.assert_called_with(
clients.tripleoclient.object_store, mock.ANY, 'overcloud')

2
tripleoclient/v1/overcloud_deploy.py
View File

@ -388,7 +388,7 @@ class DeployOvercloud(command.Command):
parameters = self._update_parameters(
parsed_args, network_client, stack)
tht_root = parsed_args.templates
tht_root = os.path.abspath(parsed_args.templates)
plans = plan_management.list_deployment_plans(workflow_client)