Disable inflight validations by default
The inflight validations caused timeouts in the TripleO CI. They should not be enabled by default. New features should not be enabled by default in general, they should be optional. So this patch changes the option to be --inflight-validations, and make sure the inflights are disabled by default everywhere it's called. Change-Id: I082628a9480686d6a7801056c3b4bf332b4e3d95 Related-Bug: #1844446
This commit is contained in:
parent
c28df729e7
commit
89be0d17c5
|
@ -1,5 +1,6 @@
|
|||
---
|
||||
features:
|
||||
- |
|
||||
Introduce new "--no-inflight-validations" option in order to deactivate
|
||||
those validations. It defaults to "False", since we want them by default.
|
||||
Introduce new "--inflight-validations" option in order to activate
|
||||
those validations. It defaults to "False", since we don't want them by
|
||||
default.
|
||||
|
|
|
@ -732,11 +732,11 @@ class DeployOvercloud(command.Command):
|
|||
'now run via the external validations in '
|
||||
'tripleo-validations.'))
|
||||
parser.add_argument(
|
||||
'--no-inflight-validations',
|
||||
'--inflight-validations',
|
||||
action='store_true',
|
||||
default=False,
|
||||
dest='no_inflight',
|
||||
help=_('Deactivate in-flight validations during the deploy. '
|
||||
dest='inflight',
|
||||
help=_('Activate in-flight validations during the deploy. '
|
||||
'In-flight validations provide a robust way to ensure '
|
||||
'deployed services are running right after their '
|
||||
'activation. Defaults to False.')
|
||||
|
@ -948,7 +948,7 @@ class DeployOvercloud(command.Command):
|
|||
timeout,
|
||||
verbosity=self.app_args.verbose_level,
|
||||
deployment_options=deployment_options,
|
||||
in_flight_validations=(not parsed_args.no_inflight))
|
||||
in_flight_validations=parsed_args.inflight)
|
||||
except Exception:
|
||||
deployment.set_deployment_status(
|
||||
self.clients, 'failed',
|
||||
|
|
|
@ -335,7 +335,7 @@ def config_download(log, clients, stack, templates,
|
|||
ssh_user, ssh_key, ssh_network,
|
||||
output_dir, override_ansible_cfg, timeout, verbosity=1,
|
||||
deployment_options={},
|
||||
in_flight_validations=True):
|
||||
in_flight_validations=False):
|
||||
workflow_client = clients.workflow_engine
|
||||
tripleoclients = clients.tripleoclient
|
||||
|
||||
|
|
Loading…
Reference in New Issue