openstack
/
python-troveclient
Code Issues Proposed changes

Corrects order of parameters to assertEqual 

The correct order of parameters to assertEqual is (expected,
actual).
It makes the assertion message more meaningful when there is
a failure.

Change-Id: Ifd35dbf6a6157c6ec7607e8ace6757b12f47657d
Closes-Bug: #1277104
This commit is contained in:
Sushil Kumar 2015-04-28 13:32:11 +00:00
parent 622f9bceb4
commit 8b1e3c3663
2 changed files with 4 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
troveclient/tests/test_client.py
View File

@ -30,7 +30,7 @@ class ClientTest(testtools.TestCase):
version_map = other_client.get_version_map()
output = client.BaseClient.get_class('database',
'1.0', version_map)
self.assertEqual(output, troveclient.v1.client.Client)
self.assertEqual(troveclient.v1.client.Client, output)
def test_get_client_class_unknown(self):
version_map = other_client.get_version_map()

6
troveclient/tests/test_discover.py
View File

@ -40,7 +40,7 @@ class DiscoverTest(testtools.TestCase):
def test():
shell = troveclient.shell.OpenStackTroveShell()
for name, module in shell._discover_via_entry_points():
self.assertEqual(name, 'foo')
self.assertEqual('foo', name)
self.assertTrue(inspect.ismodule(module))
test()
@ -68,13 +68,13 @@ class DiscoverTest(testtools.TestCase):
def test():
shell = troveclient.shell.OpenStackTroveShell()
extensions = shell._discover_extensions('1.0')
self.assertEqual(len(extensions), 3)
self.assertEqual(3, len(extensions))
names = sorted(['foo', 'bar', 'baz'])
sorted_extensions = sorted(extensions, key=lambda ext: ext.name)
for i in range(len(names)):
ext = sorted_extensions[i]
name = names[i]
self.assertEqual(ext.name, name)
self.assertEqual(name, ext.name)
self.assertTrue(inspect.ismodule(ext.module))
test()