openstack
/
rally
Code Issues Proposed changes

test: make enforce_type=True in CONF.set_override 

Each config option has limitation for type and value.
In production code, oslo.conf can ensure user's input
is valid, but in unit test, test methods can pass if
we use method CONF.set_override without parameter
enforce_type=True even we pass wrong type or wrong
value to config option. This commit makes sure calling
method CONF.set_override with enforce_type=True,

Change-Id: Ib22685902103d2a2b9f032a25de19e92b40e8154
Closes-Bug: #1517839
This commit is contained in:
LiuNanke 2016-01-02 03:05:13 +08:00
parent 01ca139136
commit dfd7363092
3 changed files with 10 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
tests/unit/plugins/openstack/context/sahara/test_sahara_cluster.py
View File

@ -45,7 +45,8 @@ class SaharaClusterTestCase(test.ScenarioTestCase):
"tenant_id": str(i),
"credential": mock.MagicMock()})
CONF.set_override("sahara_cluster_check_interval", 0, "benchmark")
CONF.set_override("sahara_cluster_check_interval", 0, "benchmark",
enforce_type=True)
self.context.update({
"config": {

6
tests/unit/plugins/openstack/scenarios/sahara/test_jobs.py
View File

@ -31,8 +31,10 @@ class SaharaJobTestCase(test.ScenarioTestCase):
super(SaharaJobTestCase, self).setUp()
self.context = test.get_test_context()
CONF.set_override("sahara_cluster_check_interval", 0, "benchmark")
CONF.set_override("sahara_job_check_interval", 0, "benchmark")
CONF.set_override("sahara_cluster_check_interval", 0, "benchmark",
enforce_type=True)
CONF.set_override("sahara_job_check_interval", 0, "benchmark",
enforce_type=True)
@mock.patch(SAHARA_JOB + "._run_job_execution")
def test_create_launch_job_java(self, mock__run_job_execution):

6
tests/unit/plugins/openstack/scenarios/sahara/test_utils.py
View File

@ -41,8 +41,10 @@ class SaharaScenarioTestCase(test.ScenarioTestCase):
def setUp(self):
super(SaharaScenarioTestCase, self).setUp()
CONF.set_override("sahara_cluster_check_interval", 0, "benchmark")
CONF.set_override("sahara_job_check_interval", 0, "benchmark")
CONF.set_override("sahara_cluster_check_interval", 0, "benchmark",
enforce_type=True)
CONF.set_override("sahara_job_check_interval", 0, "benchmark",
enforce_type=True)
def test_list_node_group_templates(self):
ngts = []