openstack
/
reno
Code Issues Proposed changes

tests: Use mock decorator instead of context manager 

We're going to introduce some additional mocks here shortly which would
make the current pattern unwieldy.

Change-Id: I72d2f9e6bf5ed5fa95880aa4434725e88059a89b
This commit is contained in:
Stephen Finucane 2018-05-10 10:35:41 +01:00
parent 5b8e276418
commit 79bebc4d15
1 changed files with 29 additions and 27 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

56
reno/tests/test_cache.py
View File

@ -56,31 +56,33 @@ class TestCache(base.TestCase):
)
self.c = config.Config('.')
def test_build_cache_db(self):
with mock.patch('reno.scanner.Scanner.get_notes_by_version') as gnbv:
gnbv.return_value = self.scanner_output
db = cache.build_cache_db(
self.c,
versions_to_include=[],
)
expected = {
'notes': [
{'version': k, 'files': v}
for k, v in self.scanner_output.items()
],
'file-contents': {
'note1': {
'prelude': 'This is the prelude.\n',
},
'note2': {
'issues': [
'This is the first issue.',
'This is the second issue.',
],
},
'note3': {
'features': ['We added a feature!'],
},
@mock.patch('reno.scanner.Scanner.get_notes_by_version')
def test_build_cache_db(self, gnbv):
gnbv.return_value = self.scanner_output
expected = {
'notes': [
{'version': k, 'files': v}
for k, v in self.scanner_output.items()
],
'file-contents': {
'note1': {
'prelude': 'This is the prelude.\n',
},
}
self.assertEqual(expected, db)
'note2': {
'issues': [
'This is the first issue.',
'This is the second issue.',
],
},
'note3': {
'features': ['We added a feature!'],
},
},
}
db = cache.build_cache_db(
self.c,
versions_to_include=[],
)
self.assertEqual(expected, db)