openstack
/
sahara-dashboard
Code Issues Proposed changes

Fix attrs list of LabeledInput.render() method 

The item (and the buttom to create a new job binary) didn't work anymore
in Django 1.11, due to a change in the parameter list of the render()
method: it was previously based on the position, now the arguments are
explicitly passed using their names.

Thanks to https://github.com/springload/wagtaildraftail/issues/51
for the explanation.

Closes-Bug: #1743384
Change-Id: I241021c593ad50591f0155dfb364afbc662a4794
This commit is contained in:
Luigi Toscano 2018-01-15 15:10:18 +01:00
parent 804206bb9c
commit 5b28b7bca8
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
sahara_dashboard/content/data_processing/jobs/job_binaries/forms.py
View File

@ -33,8 +33,8 @@ from saharaclient.api import base
class LabeledInput(widgets.TextInput):
def render(self, name, values, attrs=None):
input = super(LabeledInput, self).render(name, values, attrs)
def render(self, name, value, attrs=None):
input = super(LabeledInput, self).render(name, value, attrs)
label = "<span id='%s'>%s</span>" %\
("id_%s_label" % name,
"swift://")