flake8 new release 3.8.0 added new checks and gate pep8
job start failing. hacking 3.0.1 fix the pinning of flake8 to
avoid bringing in a new version with new checks.
Though it is fixed in latest hacking but 2.0 and 3.0 has cap for
flake8 as <4.0.0 which mean flake8 new version 3.9.0 can also
break the pep8 job if new check are added.
To avoid similar gate break in future, we need to bump the hacking min
version.
- http://lists.openstack.org/pipermail/openstack-discuss/2020-May/014828.html
Change-Id: I722019df784bbc7b791f2146beb1d0ca20dd04de
Now only python 3 is supported, which means unittest.mock
can be used instead of the external mock module.
This change can be done thanks to the Horizon
change I2de669d8e89b8daeb7ee5405ffab35af6307c40b
Switch to openstack-lower-constraints-jobs-horizon
which pulls in the last horizon. The lower-constraint
version of horizon should be bumped when a new
version (post-18.2.0) is released.
Finally, add pytest to the set of test requirements
to prevent an missing import error (even through
the sahara scenario tests still need to be ported
to pytest).
Change-Id: I2c61e9d88b2d05c9f0b68066d7bb15b43cdf083f
The repo is Python 3 now, so update hacking to version 3.0 which
supports Python 3.
Fix problems found.
Update local hacking checks for new flake8.
Remove hacking and friends from lower-constraints, it's not needed
there for co-installing.
Change-Id: I3d250ba82cc14f163f4295381b9b9c232486ac9f
nose is not actively maintained now and Django default test runner
seems to have enough features.
* Horizon test setting no longer depends on nose and related stuffs.
This commit cleans up nose related dependencies.
The change was made in horizon Rocky-3,
so horizon 14.0.0.0b3 is required at least.
* Integraion tests is marked via django.test.tag mechanism which is
introduced in Django 1.10.
* Rename filename of test files to names starting with 'test_'
so that the django test runner can find tests expectedly.
* run_tests.sh is no longer called from tox.ini, so it can be dropped.
Note that the similar run_tests.sh in horizon was dropped long ago.
Change-Id: I1e5471078cc95031e8819f01100319a9ee2a3a73
The porting to mock of sahara-dashboard is complete.
This fulfills the community goal
"Remove Use of mox/mox3 for Testing" set for Rocky:
https://governance.openstack.org/tc/goals/rocky/mox_removal.html
Raise the requirement to the Rocky M2 release of Horizon,
which drops the usage of mox by default (it should be
explicitly enabled). Without a forced import from Horizon
the mox dependencies can be dropped here.
Bump also a dependency needed by this new version of Horizon.
Change-Id: Iaf272af9919f8a69562c0a469130bbf8628936cf
It was broken for a long while, since the migration
of the dashboard code into Horizon, and then back
into this repository, as .testr.conf was removed.
Use coverage directly instead of testrepository,
the same way as Horizon does. We should port
the normal test runner to the Django test runner too,
instead of the custom run_tests.sh script, but
that's for another (future) review.
Change-Id: I08966ddc7e891156a1c934bb115ce8a02f77ec83
Create a tox environment for running the unit tests against the lower
bounds of the dependencies.
Create a lower-constraints.txt to be used to enforce the lower bounds
in those tests.
Add openstack-tox-lower-constraints job to the zuul configuration.
See http://lists.openstack.org/pipermail/openstack-dev/2018-March/128352.html
for more details.
---
sahara-dashboard specific changes:
- sahara-dashboard uses django.urls module which is only available in
Django 1.11 or later, so the Django min version needs to be bumped to 1.11.
Horizon Rocky bumped the Django min version
to >=1.11
- django-babel needs to bumped to 0.6.2 to support Django 1.11 and 2.0.
- nose-exclude needs to bumped to 0.5.0 to run all existing unit tests.
https://review.openstack.org/555402 allows us to bump lower requirements.
Co-Authored-By: Akihiro Motoki <amotoki@gmail.com>
Change-Id: I6cc5d973ea0e586e6fbe2ab4ba1345857722d008
Depends-On: https://review.openstack.org/555034
Depends-On: https://review.openstack.org/555402
Signed-off-by: Doug Hellmann <doug@doughellmann.com>
Signed-off-by: Akihiro Motoki <amotoki@gmail.com>
Instead of using tox-install.sh, we can install
horizon now directly from pypi - or use the current branch in CI system
using tox-siblings.
Create doc/requirements.txt for doc requirements as well, it's use
currently only for releasenotes. Remove obsolete oslosphinx requirement.
Remove docs environment - this project has no docs, only releasenotes.
Update tox.ini for this change and add horizon to requirements
file.
Change-Id: I72a942149a88183a32afc0440ead7b927bdc93b5
Release notes are version independent, so remove version/release
values. We've found that projects now require the service package
to be installed in order to build release notes, and this is entirely
due to the current convention of pulling in the version information.
Release notes should not need installation in order to build, so this
unnecessary version setting needs to be removed.
Also, use openstackdocstheme for releasenotes.
This is needed for new release notes publishing, see
I56909152975f731a9d2c21b2825b972195e48ee8 and the discussion starting
at
http://lists.openstack.org/pipermail/openstack-dev/2017-November/124480.html
.
Change-Id: I39b0501425823fa24996f2f215fa326453ed72c9
Since pbr already landed and the old version of hacking seems not
work very well with pbr>=2, we should update it to match global
requirement.
Partial-Bug: #1668848
Change-Id: Ic274bb0da74e9bea52ac96e8fbe3809b50b3e434
This patch introduces a pip install wrapper script which
checks horizon is installed and installs it from efficient way
(try zuul-cloner first and then use the horizon git repo).
This can also avoid a problem reported in bug 1540328.
When run_tests.sh is used, horizon is installed by
the customized install_venv.py now.
run_tests.sh is not directly used in our gate jobs,
so we can always install horizon using git repo.
This idea is borrowed from neutron subpurojects.
Change-Id: Ice304957823ac1d2c63f7c417c0dc9bb9c1fa757
Related-Bug: #1540328
The horizon.utils.urlresolvers module no longer
exists, so we need to use django.core.urlresolvers.
The integration tests were always being run when
run_tests.sh was invoked. That is not desirable. This
patch addresses that by only running them when the
appropriate flags are passed. Additionally, the
nose-exclude package is added to test-requriements.txt
to allow the exclusion of the integration test directories. These 2 fixes are presented together
because tests would not pass individually, with each
patch failing on the other problem.
Change-Id: I5d3ccc8c8969992073f122f63df2c430f690a06c
Closes-Bug: #1538265
Closes-Bug: #1538159
Our code was still pointing at openstack_dashboard.
test rather than sahara_dashboard.test. This patch
should fix that and allow our tests to start passing
again. Also adding a requirement for netifaces.
Change-Id: Icea05e4cf3c55937a4b84728cc6ef63e6c944080
Ghanshyam Mann