openstack
/
sahara
Code Issues Proposed changes

Use ThreadGroup instead of separate threads 

ThreadGroup can be used for provision_ambari execution. In that case
we will wait until successful execution of provision_ambari for all
servers.

Closes-bug: 1448073
(cherry picked from commit fbcf8d979e)

Conflicts:
	sahara/plugins/hdp/ambariplugin.py

Change-Id: I60913824e15add981857caef7d5bc94cae5f9512
This commit is contained in:
Vitaly Gridnev 2015-04-24 13:50:55 +03:00 committed by Sergey Reshetnyak
parent 2a20d701d4
commit 0d0ee7a86d
1 changed files with 11 additions and 10 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

21
sahara/plugins/hdp/ambariplugin.py
View File

@ -174,9 +174,6 @@ class AmbariPlugin(p.ProvisioningPluginBase):
def convert_props_to_template(self, props):
raise NotImplementedError('not yet supported')
def _spawn(self, description, func, *args, **kwargs):
context.spawn(description, func, *args, **kwargs)
def _provision_cluster(self, name, cluster_spec, ambari_info,
servers, version):
# TODO(jspeidel): encapsulate in another class
@ -186,10 +183,12 @@ class AmbariPlugin(p.ProvisioningPluginBase):
servers[0].cluster_id,
_("Provision cluster via Ambari"), len(servers))
for server in servers:
self._spawn(
"hdp-provision-instance-%s" % server.instance.hostname(),
server.provision_ambari, ambari_info, cluster_spec)
with context.ThreadGroup() as tg:
for server in servers:
tg.spawn(
"hdp-provision-instance-%s" %
server.instance.hostname(),
server.provision_ambari, ambari_info, cluster_spec)
handler = self.version_factory.get_version_handler(version)
ambari_client = handler.get_ambari_client()
@ -325,9 +324,11 @@ class AmbariPlugin(p.ProvisioningPluginBase):
cpo.add_provisioning_step(
cluster.id, _("Provision cluster via Ambari"), len(servers))
for server in servers:
self._spawn('Ambari provisioning thread',
server.provision_ambari, ambari_info, cluster_spec)
with context.ThreadGroup() as tg:
for server in servers:
tg.spawn('Ambari provisioning thread',
server.provision_ambari,
ambari_info, cluster_spec)
ambari_client.configure_scaled_cluster_instances(
cluster.name, cluster_spec, self._get_num_hosts(cluster),