openstack
/
syntribos
Code Issues Proposed changes

Replace assertTrue(isinstance()) with assertIsInstance() 

Some of tests use different method of assertTrue(isinstance(A, B)) or
assertEqual(type(A), B). The correct way is to use assertIsInstance(A,
B) provided by testtools.

Change-Id: Ia92e870a27cc2fe4b7b07a7097410b2cb42184a0
Closes-Bug: #1268480
This commit is contained in:
Luong Anh Tuan 2017-06-05 16:49:44 +07:00
parent ffa0fe6381
commit 8f09b85892
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
tests/unit/test_time_checks.py
View File

@ -60,8 +60,8 @@ class TimeCheckUnittest(testtools.TestCase):
signal_0 = time_checks.percentage_difference(self.test_0)
signal_1 = time_checks.percentage_difference(self.test_1)
self.assertIsNone(signal_0)
self.assertTrue(isinstance(signal_1, syntribos.signal.SynSignal))
self.assertIsInstance(signal_1, syntribos.signal.SynSignal)
def test_absolute_time(self):
signal_0 = time_checks.absolute_time(self.test_0)
self.assertTrue(isinstance(signal_0, syntribos.signal.SynSignal))
self.assertIsInstance(signal_0, syntribos.signal.SynSignal)