Use ANSIBLE_HOST_KEY_CHECKING var instead of ssh-common-args

ssh-common-args get ignored in ansible 2.4 due to
https://github.com/ansible/ansible/issues/30720
This change adds the use of ANSIBLE_HOST_KEY_CHECKING env var as
a replacement for the ssh-common-args cli option.

Closes-bug: 1725224

Change-Id: I398e93d57f6155b59c3f049558558b3a18f4762c

workbooks/access.yaml

@@ -90,6 +90,8 @@ workflows:
       - tasks
       - queue_name: tripleo
       - overcloud_admin: tripleo-admin
+      - ansible_extra_env_variables:
+            ANSIBLE_HOST_KEY_CHECKING: 'False'
     tags:
       - tripleo-common-managed
     tasks:
@@ -128,7 +130,7 @@ workflows:
               hosts: <% $.servers.addresses.ctlplane.addr.flatten().toDict($, {}) %>
           remote_user: <% $.overcloud_admin %>
           ssh_private_key: <% $.privkey %>
-          ssh_common_args: '-o StrictHostKeyChecking=no'
+          extra_env_variables: <% $.ansible_extra_env_variables %>
           playbook:
             - hosts: overcloud
               gather_facts: no
@@ -144,6 +146,9 @@ workflows:
       - ssh_private_key
       - ssh_user
       - ssh_servers
+      - ansible_extra_env_variables:
+            ANSIBLE_HOST_KEY_CHECKING: 'False'
+
     tags:
       - tripleo-common-managed
     tasks:
@@ -155,7 +160,7 @@ workflows:
               hosts: <% $.ssh_servers.toDict($, {}) %>
           remote_user: <% $.ssh_user %>
           ssh_private_key: <% $.ssh_private_key %>
-          ssh_common_args: '-o StrictHostKeyChecking=no'
+          extra_env_variables: <% $.ansible_extra_env_variables %>
           become: true
           become_user: root
           playbook:

workbooks/ceph-ansible.yaml

@@ -17,6 +17,7 @@ workflows:
           ANSIBLE_LOG_PATH: /var/log/mistral/ceph-install-workflow.log
           ANSIBLE_LIBRARY: /usr/share/ceph-ansible/library/
           ANSIBLE_SSH_RETRIES: '3'
+          ANSIBLE_HOST_KEY_CHECKING: 'False'
       - ceph_ansible_extra_vars: {}
       - ceph_ansible_playbook: /usr/share/ceph-ansible/site-docker.yml.sample
     tags:
@@ -82,8 +83,6 @@ workflows:
           verbosity: <% $.ansible_playbook_verbosity %>
           forks: <% $.fork_count %>
           ssh_private_key: <% $.private_key %>
-          ssh_common_args: '-o StrictHostKeyChecking=no'
-          ssh_extra_args: '-o UserKnownHostsFile=/dev/null'
           skip_tags: <% $.ansible_skip_tags %>
           extra_env_variables: <% $.ansible_extra_env_variables %>
           extra_vars: <% $.extra_vars %>

workbooks/fernet-key-rotate.yaml

@@ -10,6 +10,8 @@ workflows:
     input:
       - container
       - queue_name: tripleo
+      - ansible_extra_env_variables:
+            ANSIBLE_HOST_KEY_CHECKING: 'False'
 
     tags:
       - tripleo-common-managed
@@ -55,7 +57,7 @@ workflows:
           hosts: keystone
           inventory: /usr/bin/tripleo-ansible-inventory
           ssh_private_key: <% task(get_privkey).result %>
-          ssh_extra_args: '-o StrictHostKeyChecking=no'
+          extra_env_variables: <% $.ansible_extra_env_variables %>
           verbosity: 0
           remote_user: heat-admin
           become: true

workbooks/package_update.yaml

@@ -72,6 +72,8 @@ workflows:
       - inventory_file
       - queue_name: tripleo
       - module_path: /usr/share/ansible-modules
+      - ansible_extra_env_variables:
+            ANSIBLE_HOST_KEY_CHECKING: 'False'
 
     tags:
       - tripleo-common-managed
@@ -100,7 +102,7 @@ workflows:
           become_user: root
           verbosity: 0
           ssh_private_key: <% $.private_key %>
-          ssh_extra_args: '-o StrictHostKeyChecking=no'
+          extra_env_variables: <% $.ansible_extra_env_variables %>
           limit_hosts: <% $.nodes %>
           module_path: <% $.module_path %>
         on-success: node_update_passed

workbooks/skydive-ansible.yaml

@@ -12,6 +12,7 @@ workflows:
           ANSIBLE_ROLES_PATH: /usr/share/skydive-ansible/roles/
           ANSIBLE_RETRY_FILES_ENABLED: 'False'
           ANSIBLE_LOG_PATH: /var/log/mistral/skydive-install-workflow.log
+          ANSIBLE_HOST_KEY_CHECKING: 'False'
       - skydive_ansible_extra_vars: {}
       - skydive_ansible_playbook: /usr/share/skydive-ansible/playbook.yml.sample
     tags:
@@ -60,8 +61,6 @@ workflows:
           verbosity: <% $.ansible_playbook_verbosity %>
           forks: <% $.fork_count %>
           ssh_private_key: <% $.private_key %>
-          ssh_common_args: '-o StrictHostKeyChecking=no'
-          ssh_extra_args: '-o UserKnownHostsFile=/dev/null'
           extra_env_variables: <% $.ansible_extra_env_variables %>
           extra_vars: <% $.extra_vars %>
         publish: