openstack
/
tripleo-common
Code Issues Proposed changes

Don't mock mkdtemp in test_plan.py either 

Same reasoning as I04f3f569ff904e002758098cfd90b5bbb31c6afc.

Change-Id: I3be7c8e315f1e765c0512619f04a5cb4bc9bb6fc
Closes-Bug: 1714306
This commit is contained in:
Ben Nemec 2017-09-01 16:44:44 +00:00
parent 0be202dcd1
commit 2edc35c840
1 changed files with 1 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
tripleo_common/tests/actions/test_plan.py
View File

@ -302,8 +302,7 @@ class ExportPlanActionTest(base.TestCase):
self.ctx = mock.MagicMock()
@mock.patch('tripleo_common.utils.tarball.create_tarball')
@mock.patch('tempfile.mkdtemp')
def test_run_success(self, mock_mkdtemp, mock_create_tarball):
def test_run_success(self, mock_create_tarball):
get_object_mock_calls = [
mock.call(self.plan, tf) for tf in self.template_files
]
@ -311,7 +310,6 @@ class ExportPlanActionTest(base.TestCase):
mock.call(self.plan),
mock.call('plan-exports')
]
mock_mkdtemp.return_value = '/tmp/test123'
action = plan.ExportPlanAction(self.plan, self.delete_after,
self.exports_container)