openstack
/
tripleo-common
Code Issues Proposed changes

Don't upcall run on UpdateParametersAction errors 

When template validation fails, we don't need to call
ProcessTemplatesAction.run all over again, we can just call
_process_custom_roles which will take care of regenerating the env
properly.

Change-Id: Id7e0c7df7b63645058b8ecb1efcae186678fcb7c
Closes-Bug: #1805439
This commit is contained in:
Thomas Herve 2018-11-27 15:07:04 +01:00
parent 7caf2065ba
commit 8bfa3517a4
1 changed files with 1 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
tripleo_common/actions/parameters.py
View File

@ -199,8 +199,7 @@ class UpdateParametersAction(templates.ProcessTemplatesAction):
# There has been an error validating we must reprocess the
# templates with the saved working env
plan_utils.put_env(swift, saved_env)
env = saved_env
processed_data = super(UpdateParametersAction, self).run(context)
self._process_custom_roles(context)
err_msg = ("Error validating environment for plan %s: %s" % (
self.container, err))