openstack
/
tripleo-image-elements
Code Issues Proposed changes

Don't enable services in os-svc-install 

Now that we call os-svc-enable in the individual elements we
can drop the call here.

With this commit *most* services will no longer autostart on first boot
and will rely on post-configuration scripts in os-refresh-config
to enable services. This should clean up our first boot logs
quite a bit...

Change-Id: Ied3622a5e7fce4c3ac2fbd9a0e513ae877cafc5d
This commit is contained in:
Dan Prince 2013-12-01 15:28:17 -05:00
parent f99ec6e8a4
commit bac203b672
2 changed files with 3 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
elements/os-svc-install/README.md
View File

@ -2,12 +2,15 @@ Command line utilities to simplify installation of OpenStack services.
## os-svc-install
Given a git repo url, pip-install the repo and all of its python dependencies into a virtualenv under /opt/stack/venvs.
NOTE: By default services do not autostart until os-svc-enable is called.
## os-svc-daemon
Given a system service command line and run-as user, generate and install system service start script. See output of `os-svc-daemon -h` for online help.
## os-svc-enable
Enable the given service name so it starts on boot.
This is typically called in an os-refresh-config/post-configure.d script to
enable a service once it has been fully configured.
## os-svc-enable-upstart (upstart distros only)
Given an upstart job and an action, acts on the enabled or disabled state
@ -26,6 +29,5 @@ os-svc-install -u nova -n nova-all -c 'nova-all --someoption' -r https://github.
os-svc-daemon -e 'foo=bar bar=baz' -n nova-api -u nova -c /opt/stack/venvs/nova/bin/nova-api -- --config-dir /etc/nova
# enable nova-api so that it starts on boot
# NOTE: for now this is called in os-svc-daemon for legacy element support
os-svc-enable -n nova-api
```

6
elements/os-svc-install/bin/os-svc-daemon
View File

@ -157,9 +157,3 @@ elif [ "$DIB_INIT_SYSTEM" == "systemd" ]; then
fi
install_systemd $SERVICENAME $RUNAS $RUNCMD $*
fi
# Ideally we wouldn't enable services until *after* the first
# time it gets configured. Until we update elements to support
# this new logic we call os-svc-enable manually here for backwards
# compatability.
os-svc-enable -n $SERVICENAME