Correct reproducer dependency detection and adds missing git

Use of exit instead of return in the check dependecy function prevented
us to list all missing dependencies before exiting.

Avoid case where user needs to run the script 6 or more times in order
to install missing dependencies.

Adds git which was a missing dependency.

Change-Id: I66f883bbd817ce809261b7408c945e527ab72549
Partial-Bug: 1787912
This commit is contained in:
Sorin Sbarnea 2018-12-17 15:45:13 +00:00
parent dc8b496a09
commit 74e8e614f6
1 changed files with 5 additions and 3 deletions

View File

@ -167,14 +167,16 @@ function check_installed {
if ! which $binary >/dev/null ; then
echo "Error: Could not find required binary $binary. Ensure you have
it installed before trying again."
exit 1
return 1
fi
}
BOOTSTRAP_DEPENDENCIES=("virtualenv" "ansible" "pip" "openstack" "heat")
BOOTSTRAP_DEPENDENCIES=("git" "virtualenv" "ansible" "pip" "openstack" "heat")
function check_bootstrap_dependencies {
status=0
for dependency in ${BOOTSTRAP_DEPENDENCIES[@]} ; do
check_installed $dependency
check_installed $dependency || status=1
done
return $status
}
# Check that tenant credentials have been sourced