openstack
/
trove
Code Issues Proposed changes

Expect ValidationError on an empty user update 

Applying an empty change on user attributes should raise a
ValidationError.

This is needed for Trove int-tests to run on the stable/juno
branch.

Depends-On: I5ab58fd64f4745a2e558392bff649b05401ed57a
Cherry-picked-from: f8f3183527
Closes-Bug: 1482279
Change-Id: I778bb408ba1f3b58037b77e56e33ee0020156c86
This commit is contained in:
Petr Malik 2015-08-30 22:02:12 -04:00 committed by Nikhil Manchanda
parent 151f9fe169
commit 92efd0b2ef
1 changed files with 4 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
trove/tests/api/users.py
View File

@ -24,6 +24,7 @@ from proboscis.asserts import assert_false
from proboscis.asserts import assert_raises
from proboscis.asserts import assert_true
from proboscis.asserts import fail
from troveclient.openstack.common.apiclient.exceptions import ValidationError
from trove import tests
from trove.tests.api.databases import TestDatabases
@ -91,7 +92,7 @@ class TestUsers(object):
users.append({"name": self.username, "password": self.password,
"databases": [{"name": self.db1}]})
users.append({"name": self.username1, "password": self.password1,
"databases": [{"name": self.db1}, {"name": self.db2}]})
"databases": [{"name": self.db1}, {"name": self.db2}]})
self.dbaas.users.create(instance_info.id, users)
assert_equal(202, self.dbaas.last_http_code)
@ -123,7 +124,7 @@ class TestUsers(object):
users.append({"name": self.username, "password": self.password,
"databases": [{"name": self.db1}]})
users.append({"name": self.username1, "password": self.password1,
"databases": [{"name": self.db1}, {"name": self.db2}]})
"databases": [{"name": self.db1}, {"name": self.db2}]})
assert_raises(exceptions.BadRequest, self.dbaas.users.create,
instance_info.id, users)
assert_equal(400, self.dbaas.last_http_code)
@ -320,7 +321,7 @@ class TestUsers(object):
"host": hostname, "databases": []})
self.dbaas.users.create(instance_info.id, users)
user_new = {}
assert_raises(Exception,
assert_raises(ValidationError,
self.dbaas.users.update_attributes, instance_info.id,
username, user_new, hostname)
# The last_http_code doesn't have to be checked, since the exception